From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Corinna Vinschen <vinschen@redhat.com>,
Hariprasad Kelam <hkelam@marvell.com>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Naama Meir <naamax.meir@linux.intel.com>,
netdev@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: [PATCH 2/2] igc: Use PCI device pointer in logging in igc_ptp_init()
Date: Sat, 1 Jun 2024 08:06:01 +0300 [thread overview]
Message-ID: <20240601050601.1782063-3-mika.westerberg@linux.intel.com> (raw)
In-Reply-To: <20240601050601.1782063-1-mika.westerberg@linux.intel.com>
As described in the commit 86167183a17e ("igc: fix a log entry using
uninitialized netdev"), the netdev has not yet been registered so we get
weird log entry like:
[ 5.133667] igc 0000:01:00.0 (unnamed net_device) (uninitialized): PHC added
Fix this by using the PCI device pointer instead, that's valid and
available at this point.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/net/ethernet/intel/igc/igc_ptp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_ptp.c b/drivers/net/ethernet/intel/igc/igc_ptp.c
index 1bb026232efc..c4a5ddbe6f34 100644
--- a/drivers/net/ethernet/intel/igc/igc_ptp.c
+++ b/drivers/net/ethernet/intel/igc/igc_ptp.c
@@ -1169,9 +1169,9 @@ void igc_ptp_init(struct igc_adapter *adapter)
&adapter->pdev->dev);
if (IS_ERR(adapter->ptp_clock)) {
adapter->ptp_clock = NULL;
- netdev_err(netdev, "ptp_clock_register failed\n");
+ dev_err(&adapter->pdev->dev, "ptp_clock_register failed\n");
} else if (adapter->ptp_clock) {
- netdev_info(netdev, "PHC added\n");
+ dev_info(&adapter->pdev->dev, "PHC added\n");
adapter->ptp_flags |= IGC_PTP_ENABLED;
}
}
--
2.43.0
prev parent reply other threads:[~2024-06-01 5:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-01 5:05 [PATCH 0/2] igc: fix BUG() during the driver probe Mika Westerberg
2024-06-01 5:06 ` [PATCH 1/2] Revert "igc: fix a log entry using uninitialized netdev" Mika Westerberg
2024-06-01 6:16 ` Linux regression tracking (Thorsten Leemhuis)
2024-06-01 5:06 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240601050601.1782063-3-mika.westerberg@linux.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkelam@marvell.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=naamax.meir@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vinicius.gomes@intel.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).