From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: edumazet@google.com, pabeni@redhat.com, davem@davemloft.net,
netdev@vger.kernel.org, mptcp@lists.linux.dev,
matttbe@kernel.org, martineau@kernel.org, borisp@nvidia.com
Subject: Re: [PATCH net-next 2/3] tcp: add a helper for setting EOR on tail skb
Date: Sat, 1 Jun 2024 14:56:20 -0700 [thread overview]
Message-ID: <20240601145620.065e6a5d@kernel.org> (raw)
In-Reply-To: <6659d38ac31fa_3f8cab29482@willemb.c.googlers.com.notmuch>
On Fri, 31 May 2024 09:41:30 -0400 Willem de Bruijn wrote:
> > +static inline void tcp_write_collapse_fence(struct sock *sk)
> > +{
>
> const struct ptr?
Maybe just me, but feels kinda weird for the sole input to be const
if the function does modify the object it operates on.
next prev parent reply other threads:[~2024-06-01 21:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 23:36 [PATCH net-next 0/3] tcp: refactor skb_cmp_decrypted() checks Jakub Kicinski
2024-05-30 23:36 ` [PATCH net-next 1/3] tcp: wrap mptcp and decrypted checks into tcp_skb_can_collapse_rx() Jakub Kicinski
2024-05-31 8:39 ` Eric Dumazet
2024-05-31 8:53 ` Matthieu Baerts
2024-05-31 13:43 ` Willem de Bruijn
2024-05-30 23:36 ` [PATCH net-next 2/3] tcp: add a helper for setting EOR on tail skb Jakub Kicinski
2024-05-31 8:39 ` Eric Dumazet
2024-05-31 13:41 ` Willem de Bruijn
2024-06-01 21:56 ` Jakub Kicinski [this message]
2024-06-02 1:35 ` Willem de Bruijn
2024-05-30 23:36 ` [PATCH net-next 3/3] net: skb: add compatibility warnings to skb_shift() Jakub Kicinski
2024-05-31 8:40 ` Eric Dumazet
2024-05-31 13:41 ` Willem de Bruijn
2024-06-04 11:30 ` [PATCH net-next 0/3] tcp: refactor skb_cmp_decrypted() checks patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240601145620.065e6a5d@kernel.org \
--to=kuba@kernel.org \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).