From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <horms@kernel.org>
Cc: "Thorsten Blum" <thorsten.blum@toblux.com>,
"Nicolas Pitre" <nico@fluxnic.net>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Breno Leitao" <leitao@debian.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
"Andrew Lunn" <andrew@lunn.ch>, "Arnd Bergmann" <arnd@arndb.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: smc91x: Refactor SMC_* macros
Date: Sat, 1 Jun 2024 15:42:13 -0700 [thread overview]
Message-ID: <20240601154213.7274767f@kernel.org> (raw)
In-Reply-To: <20240601165342.GS491852@kernel.org>
On Sat, 1 Jun 2024 17:53:42 +0100 Simon Horman wrote:
> > drivers/net/ethernet/smsc/smc91x.c | 132 +++++++++++--------------
> > drivers/net/ethernet/smsc/smc91x.h | 152 ++++++++++++++---------------
> > 2 files changed, 131 insertions(+), 153 deletions(-)
>
> This is a large and repetitive patch, which makes it hard to spot any errors
> (I couldn't see any :)
+1
While the spirit of the patch is right, I don't think we should
encouraging refactoring of ancient drivers. It's not a great use
of anyone's time.
prev parent reply other threads:[~2024-06-01 22:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 12:01 [PATCH net-next v2] net: smc91x: Refactor SMC_* macros Thorsten Blum
2024-06-01 16:53 ` Simon Horman
2024-06-01 22:42 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240601154213.7274767f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=horms@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=pabeni@redhat.com \
--cc=thorsten.blum@toblux.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).