From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
virtualization@lists.linux.dev, bpf@vger.kernel.org
Subject: Re: [PATCH net-next v2 12/12] virtio_net: refactor the xmit type
Date: Sun, 2 Jun 2024 15:50:42 -0400 [thread overview]
Message-ID: <20240602154943-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20240530112406.94452-13-xuanzhuo@linux.alibaba.com>
On Thu, May 30, 2024 at 07:24:06PM +0800, Xuan Zhuo wrote:
> +enum virtnet_xmit_type {
> + VIRTNET_XMIT_TYPE_SKB,
> + VIRTNET_XMIT_TYPE_XDP,
> +};
> +
> +#define VIRTNET_XMIT_TYPE_MASK (VIRTNET_XMIT_TYPE_SKB | VIRTNET_XMIT_TYPE_XDP)
No idea how this has any chance to work.
Was this tested, even?
--
MST
next prev parent reply other threads:[~2024-06-02 19:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 11:23 [PATCH net-next v2 00/12] virtnet_net: prepare for af-xdp Xuan Zhuo
2024-05-30 11:23 ` [PATCH net-next v2 01/12] virtio_net: independent directory Xuan Zhuo
2024-05-30 11:23 ` [PATCH net-next v2 02/12] virtio_net: move core structures to virtio_net.h Xuan Zhuo
2024-05-30 11:23 ` [PATCH net-next v2 03/12] virtio_net: add prefix virtnet to all struct inside virtio_net.h Xuan Zhuo
2024-05-30 11:23 ` [PATCH net-next v2 04/12] virtio_net: separate virtnet_rx_resize() Xuan Zhuo
2024-05-30 11:23 ` [PATCH net-next v2 05/12] virtio_net: separate virtnet_tx_resize() Xuan Zhuo
2024-05-30 11:24 ` [PATCH net-next v2 06/12] virtio_net: separate receive_mergeable Xuan Zhuo
2024-05-30 11:24 ` [PATCH net-next v2 07/12] virtio_net: separate receive_buf Xuan Zhuo
2024-05-30 11:24 ` [PATCH net-next v2 08/12] virtio_ring: introduce vring_need_unmap_buffer Xuan Zhuo
2024-05-30 11:24 ` [PATCH net-next v2 09/12] virtio_ring: introduce dma map api for page Xuan Zhuo
2024-05-30 11:24 ` [PATCH net-next v2 10/12] virtio_ring: introduce virtqueue_dma_map_sg_attrs Xuan Zhuo
2024-05-30 11:24 ` [PATCH net-next v2 11/12] virtio_ring: virtqueue_set_dma_premapped() support to disable Xuan Zhuo
2024-05-30 11:24 ` [PATCH net-next v2 12/12] virtio_net: refactor the xmit type Xuan Zhuo
2024-06-02 19:50 ` Michael S. Tsirkin [this message]
2024-05-30 11:53 ` [PATCH net-next v2 00/12] virtnet_net: prepare for af-xdp Michael S. Tsirkin
2024-05-30 11:54 ` Xuan Zhuo
2024-05-31 1:40 ` Xuan Zhuo
2024-05-31 1:55 ` Jakub Kicinski
2024-05-31 1:57 ` Xuan Zhuo
2024-06-01 1:01 ` Xuan Zhuo
2024-06-02 19:49 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240602154943-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).