Re: [PATCH net-next 1/8] net: dsa: ocelot: use devres in ocelot_ext_probe()

[Vladimir Oltean <vladimir.oltean@nxp.com>]

On Sun, Jun 02, 2024 at 09:00:01PM -0500, Colin Foster wrote:
> On Thu, May 30, 2024 at 07:33:26PM +0300, Vladimir Oltean wrote:
> > Russell King suggested that felix_vsc9959, seville_vsc9953 and
> > ocelot_ext have a large portion of duplicated init and teardown code,
> > which could be made common [1]. The teardown code could even be
> > simplified away if we made use of devres, something which is used here
> > and there in the felix driver, just not very consistently.
> > 
> > [1] https://lore.kernel.org/all/Zh1GvcOTXqb7CpQt@shell.armlinux.org.uk/
> > 
> > Prepare the ground in the ocelot_ext driver, by allocating the data
> > structures using devres and deleting the kfree() calls. This also
> > deletes the "Failed to allocate ..." message, since memory allocation
> > errors are extremely loud anyway, and it's hard to miss them.
> > 
> > Suggested-by: "Russell King (Oracle)" <linux@armlinux.org.uk>
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > ---
> >  drivers/net/dsa/ocelot/ocelot_ext.c | 24 +++++-------------------
> > 1 file changed, 5 insertions(+), 19 deletions(-)
> > 
> > diff --git a/drivers/net/dsa/ocelot/ocelot_ext.c b/drivers/net/dsa/ocelot/ocelot_ext.c
> > index a8927dc7aca4..c893f3ee238b 100644
> > --- a/drivers/net/dsa/ocelot/ocelot_ext.c
> > +++ b/drivers/net/dsa/ocelot/ocelot_ext.c
> 
> I found my issue and was able to test the series.
> 
> Tested-by: Colin Foster <colin.foster@in-advantage.com>

Thanks for testing, Colin.