From: Simon Horman <horms@kernel.org>
To: linux@treblig.org
Cc: allison.henderson@oracle.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr'
Date: Tue, 4 Jun 2024 18:08:02 +0100 [thread overview]
Message-ID: <20240604170802.GC791188@kernel.org> (raw)
In-Reply-To: <20240531233307.302571-1-linux@treblig.org>
On Sat, Jun 01, 2024 at 12:33:07AM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'rds_ib_dereg_odp_mr' has been unused since the original
> commit 2eafa1746f17 ("net/rds: Handle ODP mr
> registration/unregistration").
nit: Maybe commit lines are best not line-wrapped.
I'm unsure.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
The above not withstanding, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-06-04 17:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 23:33 [PATCH] RDMA/rds: remove unused struct 'rds_ib_dereg_odp_mr' linux
2024-06-04 17:08 ` Simon Horman [this message]
2024-06-04 17:32 ` Dr. David Alan Gilbert
2024-06-04 17:51 ` Allison Henderson
2024-07-20 0:28 ` Dr. David Alan Gilbert
2024-07-21 7:05 ` Leon Romanovsky
2024-07-21 11:02 ` Dr. David Alan Gilbert
2024-07-21 12:06 ` Leon Romanovsky
2024-07-29 21:01 ` Dr. David Alan Gilbert
2024-07-21 6:41 ` Zhu Yanjun
2024-07-21 10:59 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604170802.GC791188@kernel.org \
--to=horms@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux@treblig.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).