From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: "Marek Behún" <kabel@kernel.org>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next v3 1/2] net: dsa: deduplicate code adding / deleting the port address to fdb
Date: Wed, 5 Jun 2024 17:15:17 +0300 [thread overview]
Message-ID: <20240605141517.6rksxmkzgdi4bu32@skbuf> (raw)
In-Reply-To: <20240605133329.6304-2-kabel@kernel.org> <20240605133329.6304-2-kabel@kernel.org>
On Wed, Jun 05, 2024 at 03:33:28PM +0200, Marek Behún wrote:
> The sequence
> if (dsa_switch_supports_uc_filtering(ds))
> dsa_port_standalone_host_fdb_add(dp, addr, 0);
> if (!ether_addr_equal(addr, conduit->dev_addr))
> dev_uc_add(conduit, addr);
> is executed both in dsa_user_open() and dsa_user_set_mac_addr().
>
> Its reverse is executed both in dsa_user_close() and
> dsa_user_set_mac_addr().
>
> Refactor these sequences into new functions dsa_user_host_uc_install()
> and dsa_user_host_uc_uninstall().
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
next prev parent reply other threads:[~2024-06-05 14:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 13:33 [PATCH net-next v3 0/2] Fix changing DSA conduit Marek Behún
2024-06-05 13:33 ` [PATCH net-next v3 1/2] net: dsa: deduplicate code adding / deleting the port address to fdb Marek Behún
2024-06-05 14:15 ` Vladimir Oltean [this message]
2024-06-05 13:33 ` [PATCH net-next v3 2/2] net: dsa: update the unicast MAC address when changing conduit Marek Behún
2024-06-10 12:50 ` [PATCH net-next v3 0/2] Fix changing DSA conduit patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240605141517.6rksxmkzgdi4bu32@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kabel@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox