From: Jakub Kicinski <kuba@kernel.org>
To: Mengyuan Lou <mengyuanlou@net-swift.com>
Cc: netdev@vger.kernel.org, jiawenwu@trustnetic.com,
duanqiangwen@net-swift.com
Subject: Re: [PATCH net-next v4 0/6] add sriov support for wangxun NICs
Date: Wed, 5 Jun 2024 17:42:26 -0700 [thread overview]
Message-ID: <20240605174226.2b55ebc4@kernel.org> (raw)
In-Reply-To: <3601E5DE87D2BC4F+20240604155850.51983-1-mengyuanlou@net-swift.com>
On Tue, 4 Jun 2024 23:57:29 +0800 Mengyuan Lou wrote:
> Add sriov_configure for ngbe and txgbe drivers.
> Reallocate queue and irq resources when sriov is enabled.
> Add wx_msg_task in interrupts handler, which is used to process the
> configuration sent by vfs.
> Add ping_vf for wx_pf to tell vfs about pf link change.
You have cut out the ndo_set_vf_* calls but you seem to add no uAPI
access beyond just enabling the PCI SR-IOV capability. What's your plan
of making this actually usable? It's a very strange submission.
next prev parent reply other threads:[~2024-06-06 0:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 15:57 [PATCH net-next v4 0/6] add sriov support for wangxun NICs Mengyuan Lou
2024-06-06 0:42 ` Jakub Kicinski [this message]
2024-06-06 10:13 ` mengyuanlou
2024-06-06 13:52 ` Jakub Kicinski
2024-06-07 10:50 ` mengyuanlou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240605174226.2b55ebc4@kernel.org \
--to=kuba@kernel.org \
--cc=duanqiangwen@net-swift.com \
--cc=jiawenwu@trustnetic.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).