From: Jakub Kicinski <kuba@kernel.org>
To: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/3] net: core: Unify dstats with tstats and lstats, add generic collection helper
Date: Wed, 5 Jun 2024 19:02:12 -0700 [thread overview]
Message-ID: <20240605190212.7360a27a@kernel.org> (raw)
In-Reply-To: <20240605-dstats-v2-0-7fae03f813f3@codeconstruct.com.au>
On Wed, 05 Jun 2024 17:42:56 +0800 Jeremy Kerr wrote:
> This change unifies dstats with the other types, adds a collection
> helper (dev_get_dstats64) for ->ndo_get_stats64, and updates the single
> driver (vrf) to use this helper.
I think you can go further, instead of exporting the helpers and
hooking them in the driver, just add the handling based on
pcpu_stat_type directly in dev_get_stats().
next prev parent reply other threads:[~2024-06-06 2:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 9:42 [PATCH net-next v2 0/3] net: core: Unify dstats with tstats and lstats, add generic collection helper Jeremy Kerr
2024-06-05 9:42 ` [PATCH net-next v2 1/3] net: core,vrf: Change pcpu_dstat fields to u64_stats_t Jeremy Kerr
2024-06-05 9:42 ` [PATCH net-next v2 2/3] net: core: Implement dstats-type stats collections Jeremy Kerr
2024-06-05 9:42 ` [PATCH net-next v2 3/3] net: vrf: move to generic dstat helpers Jeremy Kerr
2024-06-06 2:02 ` Jakub Kicinski [this message]
2024-06-06 2:11 ` [PATCH net-next v2 0/3] net: core: Unify dstats with tstats and lstats, add generic collection helper Jeremy Kerr
2024-06-06 2:18 ` Jakub Kicinski
2024-06-06 3:01 ` Jeremy Kerr
2024-06-06 3:08 ` Jakub Kicinski
2024-06-06 3:24 ` Jeremy Kerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240605190212.7360a27a@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jk@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).