[PATCH net-next] net: allow rps/rfs related configs to be switched

[PATCH net-next] net: allow rps/rfs related configs to be switched

[Jason Xing]

From: Jason Xing <kernelxing@tencent.com>

After John Sperbeck reported a compile error if the CONFIG_RFS_ACCEL
is off, I found that I cannot easily enable/disable the config
because of lack of the prompt when using 'make menuconfig'. Therefore,
I decided to change rps/rfc related configs altogether.

Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
 net/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/Kconfig b/net/Kconfig
index f0a8692496ff..cea38fc2e2ef 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -290,12 +290,12 @@ config MAX_SKB_FRAGS
 	  If unsure, say 17.
 
 config RPS
-	bool
+	bool "Enable receive packet steering"
 	depends on SMP && SYSFS
 	default y
 
 config RFS_ACCEL
-	bool
+	bool "Enable hardware acceleration of RFS"
 	depends on RPS
 	select CPU_RMAP
 	default y
@@ -351,7 +351,7 @@ config BPF_STREAM_PARSER
 	  BPF_MAP_TYPE_SOCKMAP.
 
 config NET_FLOW_LIMIT
-	bool
+	bool "Enable net flow limit"
 	depends on RPS
 	default y
 	help
-- 
2.37.3

Re: [PATCH net-next] net: allow rps/rfs related configs to be switched

[Simon Horman]

On Sat, Jun 01, 2024 at 12:44:40AM +0800, Jason Xing wrote:
> From: Jason Xing <kernelxing@tencent.com>
> 
> After John Sperbeck reported a compile error if the CONFIG_RFS_ACCEL
> is off, I found that I cannot easily enable/disable the config
> because of lack of the prompt when using 'make menuconfig'. Therefore,
> I decided to change rps/rfc related configs altogether.
> 
> Signed-off-by: Jason Xing <kernelxing@tencent.com>

Hi Jason,

FWIIW, I think it would be appropriate to also add help text for each option.
And I would drop "Enable", modeling Kdoc on, f.e. CONFIG_CGROUP_NET_CLASSID.

Likewise for CONFIG_BQL, although that isn't strictly related to this
patch.

...

Re: [PATCH net-next] net: allow rps/rfs related configs to be switched

[Jason Xing]

Hello Simon,

On Wed, Jun 5, 2024 at 1:04 AM Simon Horman <horms@kernel.org> wrote:
>
> On Sat, Jun 01, 2024 at 12:44:40AM +0800, Jason Xing wrote:
> > From: Jason Xing <kernelxing@tencent.com>
> >
> > After John Sperbeck reported a compile error if the CONFIG_RFS_ACCEL
> > is off, I found that I cannot easily enable/disable the config
> > because of lack of the prompt when using 'make menuconfig'. Therefore,
> > I decided to change rps/rfc related configs altogether.
> >
> > Signed-off-by: Jason Xing <kernelxing@tencent.com>
>
> Hi Jason,
>
> FWIIW, I think it would be appropriate to also add help text for each option.
> And I would drop "Enable", modeling Kdoc on, f.e. CONFIG_CGROUP_NET_CLASSID.

Thanks for your review.

I will adjust as you suggest in the next submission.

>
> Likewise for CONFIG_BQL, although that isn't strictly related to this
> patch.

Yes, I can see. I think I could write another patch to do this since
currently I would like to submit a rps/rfs related patch.

Thanks,
Jason

Re: [PATCH net-next] net: allow rps/rfs related configs to be switched

[Simon Horman]

On Wed, Jun 05, 2024 at 08:54:03AM +0800, Jason Xing wrote:
> Hello Simon,
> 
> On Wed, Jun 5, 2024 at 1:04 AM Simon Horman <horms@kernel.org> wrote:
> >
> > On Sat, Jun 01, 2024 at 12:44:40AM +0800, Jason Xing wrote:
> > > From: Jason Xing <kernelxing@tencent.com>
> > >
> > > After John Sperbeck reported a compile error if the CONFIG_RFS_ACCEL
> > > is off, I found that I cannot easily enable/disable the config
> > > because of lack of the prompt when using 'make menuconfig'. Therefore,
> > > I decided to change rps/rfc related configs altogether.
> > >
> > > Signed-off-by: Jason Xing <kernelxing@tencent.com>
> >
> > Hi Jason,
> >
> > FWIIW, I think it would be appropriate to also add help text for each option.
> > And I would drop "Enable", modeling Kdoc on, f.e. CONFIG_CGROUP_NET_CLASSID.
> 
> Thanks for your review.
> 
> I will adjust as you suggest in the next submission.

Thanks.

> > Likewise for CONFIG_BQL, although that isn't strictly related to this
> > patch.
> 
> Yes, I can see. I think I could write another patch to do this since
> currently I would like to submit a rps/rfs related patch.

Yes, of course.
It's a separate issue.