From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9153119D898; Thu, 6 Jun 2024 06:57:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717657068; cv=none; b=dJlji2RUwFxFn9WhlX1KkM3+WtK7ga+Kfge6xjetbAwgKWXdF4jVk6TLdLImvjWhDpSya9Kf/6mzpezc3QnfiSXpq9aC1c18Aqm2kBDen1ZVDJcUuAN/f7SC/eDIkNI4liA/bwyFj6hc3q1fSIbNURXPq1sck/cBHKXLz+wvnng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717657068; c=relaxed/simple; bh=AWAgYsMCFjyvMefBAsZ3RW/Wl8868HRUypW9j9t8DcI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=i9ftJIY0dsyicuN8DW7amMIr+lWS0HlhcoCtoiJ4mWeumVS1XwvdENJ+q41uSrhzUqwO32x8MqzfbJio5ztoZxNoFP1m1SxAalX7D6n54A9b/z3NPKrvvza6MWlnr13ykovigIDcNVBvednHZaXlytnPnnt80+xnkjrmBNfTS7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=FIiZKxzz; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="FIiZKxzz" Received: by mail.gandi.net (Postfix) with ESMTPSA id 30F6260004; Thu, 6 Jun 2024 06:57:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1717657058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jgXWC6wrNxd7gBlX7Te69IijPU34lb7hb+iH3eHJsXo=; b=FIiZKxzzXuNWsWWUYEG9s1CHkdsJ69grzzhE1fJ75F9v5Ys2AuTSJdmoZO8Y7ExIAi0H9x D7UkSWOFwA5rcZ7uWjBFfyGHig5jG7cQkHEgVF9D0HIx2rFvJwWbgMivF7E88KuUExUAjK NVMGD+56L+Kkf3V0kw9e4YOZsvxoM4Qb/5J5gGmRyZmWl7vhLykq8me+cy7ve4kOYVt94T g82by/PcFlITDibCU0R6X8ywwCLUckU9bhKGGLdTSMP2xPaUR8hVa1Bo1rsBF2jx8CSVwt VWWMzrjSUKAYq1FQv6cuM6KZOxq3j2Zfkpk/bNnAYHJnLOjDDDP5f4uz4LYtBw== Date: Thu, 6 Jun 2024 08:57:34 +0200 From: Maxime Chevallier To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org, Nathan Chancellor , Antoine Tenart Subject: Re: [PATCH net-next v12 03/13] net: phy: add helpers to handle sfp phy connect/disconnect Message-ID: <20240606085734.73334c68@fedora> In-Reply-To: <20240605201025.764f0881@kernel.org> References: <20240605124920.720690-1-maxime.chevallier@bootlin.com> <20240605124920.720690-4-maxime.chevallier@bootlin.com> <20240605201025.764f0881@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: maxime.chevallier@bootlin.com Hello Jakub, On Wed, 5 Jun 2024 20:10:25 -0700 Jakub Kicinski wrote: > On Wed, 5 Jun 2024 14:49:08 +0200 Maxime Chevallier wrote: > > +/** > > + * phy_sfp_connect_phy - Connect the SFP module's PHY to the upstream PHY > > + * @upstream: pointer to the upstream phy device > > + * @phy: pointer to the SFP module's phy device > > + * > > + * This helper allows keeping track of PHY devices on the link. It adds the > > + * SFP module's phy to the phy namespace of the upstream phy > > + */ > > +int phy_sfp_connect_phy(void *upstream, struct phy_device *phy) > > We run scripts/kernel-doc with -Wall now, it wants return values > to be documented, too. OK, I'll address that and make sure to run this script on all the patches in the series. Thanks, Maxime