From: kernel test robot <lkp@intel.com>
To: Jeremy Kerr <jk@codeconstruct.com.au>,
David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] net: core,vrf: Change pcpu_dstat fields to u64_stats_t
Date: Fri, 7 Jun 2024 05:06:16 +0800 [thread overview]
Message-ID: <202406070424.JtWImJfu-lkp@intel.com> (raw)
In-Reply-To: <20240605-dstats-v1-1-1024396e1670@codeconstruct.com.au>
Hi Jeremy,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 32f88d65f01bf6f45476d7edbe675e44fb9e1d58]
url: https://github.com/intel-lab-lkp/linux/commits/Jeremy-Kerr/net-core-vrf-Change-pcpu_dstat-fields-to-u64_stats_t/20240605-143942
base: 32f88d65f01bf6f45476d7edbe675e44fb9e1d58
patch link: https://lore.kernel.org/r/20240605-dstats-v1-1-1024396e1670%40codeconstruct.com.au
patch subject: [PATCH 1/3] net: core,vrf: Change pcpu_dstat fields to u64_stats_t
config: i386-randconfig-062-20240607 (https://download.01.org/0day-ci/archive/20240607/202406070424.JtWImJfu-lkp@intel.com/config)
compiler: gcc-10 (Ubuntu 10.5.0-1ubuntu1) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240607/202406070424.JtWImJfu-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406070424.JtWImJfu-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/net/vrf.c:414:35: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct u64_stats_t [usertype] *p @@ got struct u64_stats_t [noderef] __percpu * @@
drivers/net/vrf.c:414:35: sparse: expected struct u64_stats_t [usertype] *p
drivers/net/vrf.c:414:35: sparse: got struct u64_stats_t [noderef] __percpu *
drivers/net/vrf.c: note: in included file (through include/linux/smp.h, include/linux/alloc_tag.h, include/linux/percpu.h, ...):
include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
vim +414 drivers/net/vrf.c
391
392 /* Local traffic destined to local address. Reinsert the packet to rx
393 * path, similar to loopback handling.
394 */
395 static int vrf_local_xmit(struct sk_buff *skb, struct net_device *dev,
396 struct dst_entry *dst)
397 {
398 int len = skb->len;
399
400 skb_orphan(skb);
401
402 skb_dst_set(skb, dst);
403
404 /* set pkt_type to avoid skb hitting packet taps twice -
405 * once on Tx and again in Rx processing
406 */
407 skb->pkt_type = PACKET_LOOPBACK;
408
409 skb->protocol = eth_type_trans(skb, dev);
410
411 if (likely(__netif_rx(skb) == NET_RX_SUCCESS))
412 vrf_rx_stats(dev, len);
413 else
> 414 u64_stats_inc(&dev->dstats->rx_drops);
415
416 return NETDEV_TX_OK;
417 }
418
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-06-06 21:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 6:37 [PATCH 0/3] net: core: Unify dstats with tstats and lstats, add generic collection helper Jeremy Kerr
2024-06-05 6:37 ` [PATCH 1/3] net: core,vrf: Change pcpu_dstat fields to u64_stats_t Jeremy Kerr
2024-06-06 21:06 ` kernel test robot [this message]
2024-06-05 6:37 ` [PATCH 2/3] net: core: Implement dstats-type stats collections Jeremy Kerr
2024-06-05 9:36 ` kernel test robot
2024-06-05 9:59 ` kernel test robot
2024-06-05 19:48 ` kernel test robot
2024-06-06 9:02 ` Dan Carpenter
2024-06-05 6:37 ` [PATCH 3/3] net: vrf: move to generic dstat helpers Jeremy Kerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202406070424.JtWImJfu-lkp@intel.com \
--to=lkp@intel.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).