Re: [PATCH net-next 01/13] dt-bindings: net: dsa: lantiq_gswip: Add missing phy-mode and fixed-link

Martin Schiller
2024-06-10T09:07:24Z

On 2024-06-10 10:55, Krzysztof Kozlowski wrote:
> On 06/06/2024 10:52, Martin Schiller wrote:
>> From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>>
>> The CPU port has to specify a phy-mode and either a phy or a
>> fixed-link.
>> Since GSWIP is connected using a SoC internal protocol there's no PHY
>> involved. Add phy-mode = "internal" and a fixed-link to describe the
>> communication between the PMAC (Ethernet controller) and GSWIP switch.
>
> You did nothing in the binding to describe them. You only extended
> example, which does not really matter if there is DTS with it.
>
> Best regards,
> Krzysztof

OK, so I'll update subject and commit message to signal that we only
update the example code.