Re: [PATCH net-next 04/13] net: dsa: lantiq_gswip: Don't manually call gswip_port_enable()

Martin Schiller
2024-06-07T12:12:28Z

On 2024-06-07 13:11, Vladimir Oltean wrote:
> On Thu, Jun 06, 2024 at 10:52:25AM +0200, Martin Schiller wrote:
>> From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>>
>> We don't need to manually call gswip_port_enable() from within
>> gswip_setup() for the CPU port. DSA does this automatically for us.
>>
>> Signed-off-by: Martin Blumenstingl
>> <martin.blumenstingl@googlemail.com>
>> ---
>
> Not to mention the first thing in gswip_port_enable(), which is:
>
> if (!dsa_is_user_port(ds, port))
> return 0;
>
> So the call is dead code anyway.

As you will have noticed, this code will be brought back to life in the
next
patch.