Re: [PATCH net-next 00/13] net: dsa: lantiq_gswip: code improvements

Hauke Mehrtens
2024-06-06T19:35:54Z

On 6/6/24 10:52, Martin Schiller wrote:
> This patchset for the lantiq_gswip driver is a collection of minor fixes
> and coding improvements by Martin Blumenstingl without any real changes
> in the actual functionality.
>
> Martin Blumenstingl (12):
> dt-bindings: net: dsa: lantiq_gswip: Add missing phy-mode and
> fixed-link
> net: dsa: lantiq_gswip: Only allow phy-mode = "internal" on the CPU
> port
> net: dsa: lantiq_gswip: Use dev_err_probe where appropriate
> net: dsa: lantiq_gswip: Don't manually call gswip_port_enable()
> net: dsa: lantiq_gswip: Use dsa_is_cpu_port() in
> gswip_port_change_mtu()
> net: dsa: lantiq_gswip: Change literal 6 to ETH_ALEN
> net: dsa: lantiq_gswip: Consistently use macros for the mac bridge
> table
> net: dsa: lantiq_gswip: Forbid gswip_add_single_port_br on the CPU
> port
> net: dsa: lantiq_gswip: Fix error message in
> gswip_add_single_port_br()
> net: dsa: lantiq_gswip: Fix comments in gswip_port_vlan_filtering()
> net: dsa: lantiq_gswip: Add and use a GSWIP_TABLE_MAC_BRIDGE_FID macro
> net: dsa: lantiq_gswip: Improve error message in gswip_port_fdb()
>
> Martin Schiller (1):
> net: dsa: lantiq_gswip: do also enable or disable cpu port
>
> .../bindings/net/dsa/lantiq-gswip.txt | 6 +
> drivers/net/dsa/lantiq_gswip.c | 110 +++++++++---------
> 2 files changed, 58 insertions(+), 58 deletions(-)
>
Thanks for sending this upstream. I had this on my list for a long time
but never started it.

For all patches:
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>

Hauke