Re: [PATCH net-next 01/13] dt-bindings: net: dsa: lantiq_gswip: Add missing phy-mode and fixed-link

Vladimir Oltean
2024-06-07T11:00:02Z

On Thu, Jun 06, 2024 at 10:52:22AM +0200, Martin Schiller wrote:
> From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> The CPU port has to specify a phy-mode and either a phy or a fixed-link.
> Since GSWIP is connected using a SoC internal protocol there's no PHY
> involved. Add phy-mode = "internal" and a fixed-link to describe the
> communication between the PMAC (Ethernet controller) and GSWIP switch.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

Long-term it would be good to also see a dt-schema conversion.