From: Simon Horman <horms@kernel.org>
To: "Csókás Bence" <csokas.bence@prolan.hu>
Cc: Hariprasad Kelam <hkelam@marvell.com>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH v2] net: fec: Add ECR bit macros, fix FEC_ECR_EN1588 being cleared on link-down
Date: Fri, 7 Jun 2024 15:39:59 +0100 [thread overview]
Message-ID: <20240607143959.GE27689@kernel.org> (raw)
In-Reply-To: <8be22ec7-0d91-46ba-b45e-4499b547a8d3@prolan.hu>
On Fri, Jun 07, 2024 at 11:12:56AM +0200, Csókás Bence wrote:
> Hi!
>
> On 6/7/24 10:32, Hariprasad Kelam wrote:
> > > FEC_ECR_EN1588 bit gets cleared after MAC reset in `fec_stop()`, which makes
> > > all 1588 functionality shut down on link-down. However, some functionality
> > > needs to be retained (e.g. PPS) even without link.
> > >
> >
> >
> > Since this patch is targeted for net, please add fixes tag.
>
> This issue has existed for "practically all time". I guess if I had to pick
> one commit, it would be:
>
> Fixes: 6605b730c061 FEC: Add time stamping code and a PTP hardware clock
>
> I don't know if it makes sense to add this ancient commit from 22 years ago,
> but if so, then so be it.
Thanks Csókás,
The practice is to use use even ancient commits in Fixes tags,
as it indicates how far back backports should go in theory,
even if backports don't go that far back in practice.
next prev parent reply other threads:[~2024-06-07 14:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 8:18 [PATCH v2] net: fec: Add ECR bit macros, fix FEC_ECR_EN1588 being cleared on link-down Csókás, Bence
2024-06-07 8:32 ` Hariprasad Kelam
2024-06-07 9:12 ` Csókás Bence
2024-06-07 14:39 ` Simon Horman [this message]
2024-06-10 19:13 ` Andrew Lunn
2024-06-11 8:04 ` Csókás Bence
2024-06-11 13:06 ` Andrew Lunn
2024-06-11 15:02 ` Csókás Bence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240607143959.GE27689@kernel.org \
--to=horms@kernel.org \
--cc=csokas.bence@prolan.hu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkelam@marvell.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).