From: kernel test robot <lkp@intel.com>
To: Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
netfilter-devel@vger.kernel.org, pablo@netfilter.org,
willemb@google.com, Christoph Paasch <cpaasch@apple.com>
Subject: Re: [PATCH net-next 1/2] net: add and use skb_get_hash_net
Date: Fri, 7 Jun 2024 20:33:42 +0800 [thread overview]
Message-ID: <202406072022.OkRGOAuS-lkp@intel.com> (raw)
In-Reply-To: <20240607083205.3000-2-fw@strlen.de>
Hi Florian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Florian-Westphal/net-add-and-use-skb_get_hash_net/20240607-163738
base: net-next/main
patch link: https://lore.kernel.org/r/20240607083205.3000-2-fw%40strlen.de
patch subject: [PATCH net-next 1/2] net: add and use skb_get_hash_net
config: openrisc-defconfig (https://download.01.org/0day-ci/archive/20240607/202406072022.OkRGOAuS-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240607/202406072022.OkRGOAuS-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406072022.OkRGOAuS-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> net/core/flow_dissector.c:1872: warning: Function parameter or struct member 'net' not described in '__skb_get_hash_net'
vim +1872 net/core/flow_dissector.c
eb70db8756717b David S. Miller 2016-07-01 1861
d4fd32757176d1 Jiri Pirko 2015-05-12 1862 /**
11b45a5b56dab6 Florian Westphal 2024-06-07 1863 * __skb_get_hash_net: calculate a flow hash
d4fd32757176d1 Jiri Pirko 2015-05-12 1864 * @skb: sk_buff to calculate flow hash from
d4fd32757176d1 Jiri Pirko 2015-05-12 1865 *
d4fd32757176d1 Jiri Pirko 2015-05-12 1866 * This function calculates a flow hash based on src/dst addresses
61b905da33ae25 Tom Herbert 2014-03-24 1867 * and src/dst port numbers. Sets hash in skb to non-zero hash value
61b905da33ae25 Tom Herbert 2014-03-24 1868 * on success, zero indicates no valid hash. Also, sets l4_hash in skb
441d9d327f1e77 Cong Wang 2013-01-21 1869 * if hash is a canonical 4-tuple hash over transport ports.
441d9d327f1e77 Cong Wang 2013-01-21 1870 */
11b45a5b56dab6 Florian Westphal 2024-06-07 1871 void __skb_get_hash_net(const struct net *net, struct sk_buff *skb)
441d9d327f1e77 Cong Wang 2013-01-21 @1872 {
441d9d327f1e77 Cong Wang 2013-01-21 1873 struct flow_keys keys;
635c223cfa05af Gao Feng 2016-08-31 1874 u32 hash;
441d9d327f1e77 Cong Wang 2013-01-21 1875
11b45a5b56dab6 Florian Westphal 2024-06-07 1876 memset(&keys, 0, sizeof(keys));
11b45a5b56dab6 Florian Westphal 2024-06-07 1877
11b45a5b56dab6 Florian Westphal 2024-06-07 1878 __skb_flow_dissect(net, skb, &flow_keys_dissector,
11b45a5b56dab6 Florian Westphal 2024-06-07 1879 &keys, NULL, 0, 0, 0,
11b45a5b56dab6 Florian Westphal 2024-06-07 1880 FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL);
11b45a5b56dab6 Florian Westphal 2024-06-07 1881
50fb799289501c Tom Herbert 2015-05-01 1882 __flow_hash_secret_init();
50fb799289501c Tom Herbert 2015-05-01 1883
11b45a5b56dab6 Florian Westphal 2024-06-07 1884 hash = __flow_hash_from_keys(&keys, &hashrnd);
635c223cfa05af Gao Feng 2016-08-31 1885
635c223cfa05af Gao Feng 2016-08-31 1886 __skb_set_sw_hash(skb, hash, flow_keys_have_l4(&keys));
441d9d327f1e77 Cong Wang 2013-01-21 1887 }
11b45a5b56dab6 Florian Westphal 2024-06-07 1888 EXPORT_SYMBOL(__skb_get_hash_net);
441d9d327f1e77 Cong Wang 2013-01-21 1889
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-06-07 12:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 8:31 [PATCH net-next 0/2] net: flow dissector: allow explicit passing of netns Florian Westphal
2024-06-07 8:31 ` [PATCH net-next 1/2] net: add and use skb_get_hash_net Florian Westphal
2024-06-07 9:25 ` Eric Dumazet
2024-06-07 14:13 ` Willem de Bruijn
2024-06-08 22:17 ` Florian Westphal
2024-06-07 12:33 ` kernel test robot [this message]
2024-06-07 8:32 ` [PATCH net-next 2/2] net: add and use __skb_get_hash_symmetric_net Florian Westphal
2024-06-07 9:26 ` Eric Dumazet
2024-06-07 14:14 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202406072022.OkRGOAuS-lkp@intel.com \
--to=lkp@intel.com \
--cc=cpaasch@apple.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).