From: Jakub Kicinski <kuba@kernel.org>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
pabeni@redhat.com, davem@davemloft.net, dsahern@kernel.org,
mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
eperezma@redhat.com, leitao@debian.org, netdev@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>
Subject: Re: [PATCH net-next] net: dqs: introduce NETIF_F_NO_BQL device feature
Date: Mon, 10 Jun 2024 18:45:05 -0700 [thread overview]
Message-ID: <20240610184505.35006364@kernel.org> (raw)
In-Reply-To: <CAL+tcoCGumdRKgd_1bQj1U_sNPsvYmsNOKwSWxazU0FwmeNTwA@mail.gmail.com>
On Mon, 10 Jun 2024 07:55:55 +0800 Jason Xing wrote:
> > (I think Vladimir was trying to make some room, this was a discussion
> > we had last year)
s/Vladimir/Olek/ ?
> Thanks for your reminder. When I was trying to introduce one new bit,
> I noticed an overflow warning when compiling.
>
> > I do not see the reason to report to ethtool the 'nobql bit' :
> > If a driver opts-out, then the bql sysfs files will not be there, user
> > space can see the absence of the files.
>
> The reason is that I just followed the comment to force myself to
> report to ethtool. Now I see.
>
> It seems not that easy to consider all the non-BQL drivers. Let me
> think more about it.
All Eric was saying, AFAIU, is that you can for example add a bit
in somewhere towards the end of struct nedevice, no need to pack
this info into feature bits.
BTW the Fixes tag is a bit of an exaggeration here. The heuristic in
netdev_uses_bql() is best effort, its fine to miss some devices.
next prev parent reply other threads:[~2024-06-11 1:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-09 13:17 [PATCH net-next] net: dqs: introduce NETIF_F_NO_BQL device feature Jason Xing
2024-06-09 16:42 ` Eric Dumazet
2024-06-09 23:55 ` Jason Xing
2024-06-11 1:45 ` Jakub Kicinski [this message]
2024-06-11 2:56 ` Jason Xing
2024-06-10 6:33 ` Jiri Pirko
2024-06-10 11:07 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240610184505.35006364@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=leitao@debian.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).