From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50C631FA3 for ; Tue, 11 Jun 2024 01:45:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718070307; cv=none; b=IzFrGpKy5CPO7BTN+BDzJjRoYEs8G4satgGOWDLpnQAtJMS+RXOvVq7VNU18JWQr80ZZtZqKfJv/z90Vd/ovX9xXBiNsC2fyXUMPRGs+EOwvkqsgTTeTXqOFM5hbb6wvBxymVn9qFAIU4C7977MbVDWMDV+p0Ufzlc8r1luX25w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718070307; c=relaxed/simple; bh=PL8O30wqaDPXSI3sRz9e2nqLDQOVP9S8inAYSWqhKts=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k06/L+ysBYgl60sN0nkXeK4adFHsM/xgWY+C6WxhwDbcJiv4J7E2aSZ7IHgwQ8cyeu4LRWVAXpHN4mug8lDF0ZvNcDPmRFxC+bJ5Lyc1O4A+NY2wPyym5zkRwPcRZO4zmLcfq1UD6vOjTs6Lqw9szmcKzSPMjLd8iHY2Lwn4Sq0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F4F2vqYm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F4F2vqYm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F866C2BBFC; Tue, 11 Jun 2024 01:45:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718070306; bh=PL8O30wqaDPXSI3sRz9e2nqLDQOVP9S8inAYSWqhKts=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=F4F2vqYm36kvYzcng0MMpjSxgeU4nuS3SeoGfU4zfuFPHCa5nfWmzVq5ZgoOY754U tdUpY/yr8dYPgOqYwpmtmCmnTJQ3rMFaj69whKs6FXzyWejHonkqW/4seKuScAuabh +OFQG5tZYB0H2yoX81h7nCNTlhDn96lMtGsDGYdBD3vFJymgPiLs1bKDR1Nnd98vlo kJ75DDEeaJCuq+sNYvIA2vkvPfTsSaxteIDl7QKvl0N6SkX2Ds8ggtsSQite7kf0FM YwzXJITO1l/JNjBgI8kIWQI8lknsf/pCKLKc30I6wKb3JK/xrrqiLbsqaOdLH8aEO7 aCHjo1SsT0gCw== Date: Mon, 10 Jun 2024 18:45:05 -0700 From: Jakub Kicinski To: Jason Xing Cc: Eric Dumazet , pabeni@redhat.com, davem@davemloft.net, dsahern@kernel.org, mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, leitao@debian.org, netdev@vger.kernel.org, Jason Xing Subject: Re: [PATCH net-next] net: dqs: introduce NETIF_F_NO_BQL device feature Message-ID: <20240610184505.35006364@kernel.org> In-Reply-To: References: <20240609131732.73156-1-kerneljasonxing@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 10 Jun 2024 07:55:55 +0800 Jason Xing wrote: > > (I think Vladimir was trying to make some room, this was a discussion > > we had last year) s/Vladimir/Olek/ ? > Thanks for your reminder. When I was trying to introduce one new bit, > I noticed an overflow warning when compiling. > > > I do not see the reason to report to ethtool the 'nobql bit' : > > If a driver opts-out, then the bql sysfs files will not be there, user > > space can see the absence of the files. > > The reason is that I just followed the comment to force myself to > report to ethtool. Now I see. > > It seems not that easy to consider all the non-BQL drivers. Let me > think more about it. All Eric was saying, AFAIU, is that you can for example add a bit in somewhere towards the end of struct nedevice, no need to pack this info into feature bits. BTW the Fixes tag is a bit of an exaggeration here. The heuristic in netdev_uses_bql() is best effort, its fine to miss some devices.