From: Chris Packham <chris.packham@alliedtelesis.co.nz>
To: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: [PATCH next-next] net: phy: realtek: add support for rtl8224 2.5Gbps PHY
Date: Tue, 11 Jun 2024 17:34:14 +1200 [thread overview]
Message-ID: <20240611053415.2111723-1-chris.packham@alliedtelesis.co.nz> (raw)
The Realtek RTL8224 PHY is a 2.5Gbps capable PHY. It only uses the
clause 45 MDIO interface and can leverage the support that has already
been added for the other 822x PHYs.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
Notes:
I'm currently testing this on an older kernel because the board I'm
using has a SOC/DSA switch that has a driver in openwrt for Linux 5.15.
I have tried to selectively back port the bits I need from the other
rtl822x work so this should be all that is required for the rtl8224.
There's quite a lot that would need forward porting get a working system
against a current kernel so hopefully this is small enough that it can
land while I'm trying to figure out how to untangle all the other bits.
One thing that may appear lacking is the lack of rate_matching support.
According to the documentation I have know the interface used on the
RTL8224 is (q)uxsgmii so no rate matching is required. As I'm still
trying to get things completely working that may change if I get new
information.
drivers/net/phy/realtek.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index 7ab41f95dae5..2174893c974f 100644
--- a/drivers/net/phy/realtek.c
+++ b/drivers/net/phy/realtek.c
@@ -1317,6 +1317,14 @@ static struct phy_driver realtek_drvs[] = {
.resume = rtlgen_resume,
.read_page = rtl821x_read_page,
.write_page = rtl821x_write_page,
+ }, {
+ PHY_ID_MATCH_EXACT(0x001ccad0),
+ .name = "RTL8224 2.5Gbps PHY",
+ .get_features = rtl822x_c45_get_features,
+ .config_aneg = rtl822x_c45_config_aneg,
+ .read_status = rtl822x_c45_read_status,
+ .suspend = genphy_c45_pma_suspend,
+ .resume = rtlgen_c45_resume,
}, {
PHY_ID_MATCH_EXACT(0x001cc961),
.name = "RTL8366RB Gigabit Ethernet",
--
2.45.2
next reply other threads:[~2024-06-11 5:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 5:34 Chris Packham [this message]
2024-06-11 13:21 ` [PATCH next-next] net: phy: realtek: add support for rtl8224 2.5Gbps PHY Andrew Lunn
2024-06-11 20:41 ` Chris Packham
2024-06-11 20:42 ` Chris Packham
2024-06-12 7:07 ` Marek Behún
2024-06-12 20:39 ` Chris Packham
2024-06-14 8:18 ` Paolo Abeni
2024-06-14 8:25 ` Marek Behún
2024-06-16 21:24 ` Chris Packham
2024-06-17 8:12 ` Marek Behún
2024-06-15 2:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611053415.2111723-1-chris.packham@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).