From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DC38537FF for ; Wed, 12 Jun 2024 21:40:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718228424; cv=none; b=flz0k0UlIlxWH/l+RKzrMEeBHCqxLWoEeenqE159bUq/PRKG4y1QwumujlYgHm9Cpaxoa6LYQQkcvZ0Gd410oC/CbZ527aRGxyY+195gw6i/rk3ytQIAbrXE0qvUAf6rZIQWWbJIwCYG7n3XZoq+f2Rf2f1/+kxPqVfSNAbdWb4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718228424; c=relaxed/simple; bh=yUaAV5Fl/gIYOovs56RPcBazsdM2NhoyY0GzS2kdvnQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MARJTD6G1A/K7uALSqGVz0tX22JedJ0IS7EvVorrtmjfVM7RMjk7zm1oHlAjhzfwJIgg/gYNK90xmyU+z1HQQb7vABoLSrERdQIUq7rhImBBuvfOYwHqKdX5cMpWx1JFVzkMFORE4/gTMwkFkdaZ0mEkewO9TqabMx7E2weMWlo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bXke5Ux+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bXke5Ux+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E98F4C116B1; Wed, 12 Jun 2024 21:40:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718228424; bh=yUaAV5Fl/gIYOovs56RPcBazsdM2NhoyY0GzS2kdvnQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bXke5Ux+/I3chsd4wQ9BBuyUw38smV0GzbzY3DNb9oeKhs98OUAZRFNgybLqKHerU 5R0fe4Lm3eh5LlSeDVLY975E9tOxW8jXODHN5sx1XRWPG1qnReIMwIexEQl6V6+eUw YaELICDqTpvL0zaIj6u7AJwPQ9GelLS7hR5WTrkc/TiFNAmdAVxOZlEVO1xqjtJXMm fzc0uliWujI/H1IGLSQVBTx/dBKni79RT+LmZ41sownfTuRPiyAzK70IIDxfA3rx47 7wQpWCLiPbO0GXXs/6pXfW00/fJBPAjPVNj17rVvzr70pJtklegSyUHRga70mRst3u amadXxkG87Oqg== Date: Wed, 12 Jun 2024 14:40:23 -0700 From: Jakub Kicinski To: Jason Xing Cc: edumazet@google.com, pabeni@redhat.com, davem@davemloft.net, dsahern@kernel.org, mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, leitao@debian.org, netdev@vger.kernel.org, Jason Xing Subject: Re: [PATCH net-next v2] net: dqs: introduce IFF_NO_BQL private flag for non-BQL drivers Message-ID: <20240612144023.15f8032b@kernel.org> In-Reply-To: <20240611033203.54845-1-kerneljasonxing@gmail.com> References: <20240611033203.54845-1-kerneljasonxing@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 11 Jun 2024 11:32:03 +0800 Jason Xing wrote: > +++ b/include/linux/netdevice.h > @@ -1649,6 +1649,9 @@ struct net_device_ops { > * @IFF_SEE_ALL_HWTSTAMP_REQUESTS: device wants to see calls to > * ndo_hwtstamp_set() for all timestamp requests regardless of source, > * even if those aren't HWTSTAMP_SOURCE_NETDEV. > + * @IFF_NO_BQL: driver doesn't use BQL for flow control for now. It's used > + * to check if we should create byte_queue_limits directory in dqs > + * (see netdev_uses_bql()) Sorry for nit but since it's netdevice.h.. can we rephrase the comment a bit? How about just: + * @IFF_NO_BQL: driver doesn't support BQL, don't create "byte_queue_limits" + * directories in sysfs.