public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Aryan Srivastava <aryan.srivastava@alliedtelesis.co.nz>
Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
	linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
	mw@semihalf.com, netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH v1] net: mvpp2: use slab_build_skb for oversized frames
Date: Wed, 12 Jun 2024 20:05:34 -0700	[thread overview]
Message-ID: <202406122003.E02C37ADD1@keescook> (raw)
In-Reply-To: <20240613024900.3842238-1-aryan.srivastava@alliedtelesis.co.nz>

On Thu, Jun 13, 2024 at 02:49:00PM +1200, Aryan Srivastava wrote:
> Setting frag_size to 0 to indicate kmalloc has been deprecated,
> use slab_build_skb directly.
> 
> Fixes: ce098da1497c ("skbuff: Introduce slab_build_skb()")
> Signed-off-by: Aryan Srivastava <aryan.srivastava@alliedtelesis.co.nz>
> ---
> Changes in v1:
> - Added Fixes tag

This looks like similar updates like commit 99b415fe8986 ("tg3: Use
slab_build_skb() when needed")

Reviewed-by: Kees Cook <kees@kernel.org>

-- 
Kees Cook

  reply	other threads:[~2024-06-13  3:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10  3:53 [PATCH v0] net: mvpp2: use slab_build_skb for oversized frames Aryan Srivastava
2024-06-12  2:33 ` Jakub Kicinski
2024-06-13  2:49   ` [PATCH v1] " Aryan Srivastava
2024-06-13  3:05     ` Kees Cook [this message]
2024-06-13  3:13       ` Aryan Srivastava
2024-06-13  3:34         ` Kees Cook
2024-06-13  3:39           ` Aryan Srivastava
2024-06-14  0:20     ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202406122003.E02C37ADD1@keescook \
    --to=kees@kernel.org \
    --cc=aryan.srivastava@alliedtelesis.co.nz \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mw@semihalf.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox