From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH stable-5.15.y 0/2] Fix PTP received on wrong port with bridged SJA1105 DSA
Date: Wed, 12 Jun 2024 15:58:39 +0200 [thread overview]
Message-ID: <2024061227-agony-washable-111e@gregkh> (raw)
In-Reply-To: <20240531165016.3021154-1-vladimir.oltean@nxp.com>
On Fri, May 31, 2024 at 07:50:14PM +0300, Vladimir Oltean wrote:
> It has been brought to my attention that what had been fixed 1 year ago
> here for kernels 5.18 and later:
> https://lore.kernel.org/netdev/20230626155112.3155993-1-vladimir.oltean@nxp.com/
>
> is still broken on linux-5.15.y. Short summary: PTP boundary clock is
> broken for ports under a VLAN-aware bridge.
>
> The reason is that the Fixes: tags in those patches were wrong. The
> issue originated from earlier, but the changes from 5.18 (blamed there),
> aka DSA FDB isolation, masked that.
>
> A straightforward cherry-pick was not possible, due to the conflict with
> the aforementioned DSA FDB isolation work from 5.18. So I redid patch
> 2/2 and marked what I had to adapt.
>
> Tested on the NXP LS1021A-TSN board.
>
> Vladimir Oltean (2):
> net: dsa: sja1105: always enable the INCL_SRCPT option
> net: dsa: tag_sja1105: always prefer source port information from
> INCL_SRCPT
>
> drivers/net/dsa/sja1105/sja1105_main.c | 9 ++-----
> net/dsa/tag_sja1105.c | 34 ++++++++++++++++++++------
> 2 files changed, 28 insertions(+), 15 deletions(-)
> ---
>
> I'm sorry for the people who will want to backport DSA FDB isolation to
> linux-5.15.y :(
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2024-06-12 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 16:50 [PATCH stable-5.15.y 0/2] Fix PTP received on wrong port with bridged SJA1105 DSA Vladimir Oltean
2024-05-31 16:50 ` [PATCH stable-5.15.y 1/2] net: dsa: sja1105: always enable the INCL_SRCPT option Vladimir Oltean
2024-05-31 16:50 ` [PATCH stable-5.15.y 2/2] net: dsa: tag_sja1105: always prefer source port information from INCL_SRCPT Vladimir Oltean
2024-06-12 13:58 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024061227-agony-washable-111e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox