From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: Joe Damato <jdamato@fastly.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
nalramli@fastly.com, Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
"open list:MELLANOX MLX5 core VPI driver"
<linux-rdma@vger.kernel.org>, Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [net-next v5 2/2] net/mlx5e: Add per queue netdev-genl stats
Date: Thu, 13 Jun 2024 14:58:17 -0700 [thread overview]
Message-ID: <20240613145817.32992753@kernel.org> (raw)
In-Reply-To: <0a38f58a-2b1e-4d78-90e1-eb8539f65306@gmail.com>
On Thu, 13 Jun 2024 23:25:12 +0300 Tariq Toukan wrote:
> > + for (i = priv->channels.params.num_channels; i < priv->stats_nch; i++) {
>
> IIUC, per the current kernel implementation, the lower parts won't be
> completed in a loop over [0..real_num_rx_queues-1], as that loop is
> conditional, happening only if the queues are active.
Could you rephrase this? Is priv->channels.params.num_channels
non-zero also when device is closed? I'm just guessing from
the code, TBH, I can't parse your reply :(
> I would like the kernel to drop that condition, and stop forcing the
> device driver to conditionally include this part in the base.
>
> Otherwise, the lower parts need to be added here.
You'd need a stronger (and clearly explained) argument to change
the core. If you're saying that the kernel should be able to dump
queue stats for disabled queues - that seems rather questionable.
next prev parent reply other threads:[~2024-06-13 21:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 20:08 [net-next v5 0/2] mlx5: Add netdev-genl queue stats Joe Damato
2024-06-12 20:08 ` [net-next v5 1/2] net/mlx5e: Add txq to sq stats mapping Joe Damato
2024-06-17 5:15 ` Tariq Toukan
2024-06-12 20:08 ` [net-next v5 2/2] net/mlx5e: Add per queue netdev-genl stats Joe Damato
2024-06-13 20:25 ` Tariq Toukan
2024-06-13 21:58 ` Jakub Kicinski [this message]
2024-06-13 22:12 ` Joe Damato
2024-06-13 22:36 ` Jakub Kicinski
2024-06-17 8:30 ` Tariq Toukan
2024-06-13 22:06 ` Joe Damato
2024-06-17 5:17 ` Tariq Toukan
2024-06-17 10:40 ` [net-next v5 0/2] mlx5: Add netdev-genl queue stats patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613145817.32992753@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nalramli@fastly.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).