From: Jakub Kicinski <kuba@kernel.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>, Neil Brown <neilb@suse.de>,
Olga Kornievskaia <kolga@netapp.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 5/5] nfsd: new netlink ops to get/set server pool_mode
Date: Thu, 13 Jun 2024 16:56:23 -0700 [thread overview]
Message-ID: <20240613165623.2a5150e8@kernel.org> (raw)
In-Reply-To: <20240613-nfsd-next-v3-5-3b51c3c2fc59@kernel.org>
On Thu, 13 Jun 2024 14:34:34 -0400 Jeff Layton wrote:
> + err = nla_put_string(skb, NFSD_A_POOL_MODE_MODE, buf) ||
> + nla_put_u32(skb, NFSD_A_POOL_MODE_NPOOLS, nfsd_nrpools(net));
bitwise or?
Other option would be to move sunrpc_get_pool_mode() before allocation
that way all error codes past allocations are EMSGSIZE and life is
simpler.
next prev parent reply other threads:[~2024-06-13 23:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 18:34 [PATCH v3 0/5] nfsd/sunrpc: allow starting/stopping pooled NFS server via netlink Jeff Layton
2024-06-13 18:34 ` [PATCH v3 1/5] sunrpc: fix up the special handling of sv_nrpools == 1 Jeff Layton
2024-06-13 18:34 ` [PATCH v3 2/5] nfsd: make nfsd_svc take an array of thread counts Jeff Layton
2024-06-13 18:34 ` [PATCH v3 3/5] nfsd: allow passing in array of thread counts via netlink Jeff Layton
2024-06-13 18:34 ` [PATCH v3 4/5] sunrpc: refactor pool_mode setting code Jeff Layton
2024-06-13 18:34 ` [PATCH v3 5/5] nfsd: new netlink ops to get/set server pool_mode Jeff Layton
2024-06-13 23:56 ` Jakub Kicinski [this message]
2024-06-14 0:18 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613165623.2a5150e8@kernel.org \
--to=kuba@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jlayton@kernel.org \
--cc=kolga@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tom@talpey.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).