From: Jakub Kicinski <kuba@kernel.org>
To: Vanillan Wang <songjinjian@hotmail.com>
Cc: chandrashekar.devegowda@intel.com,
chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com,
m.chetan.kumar@linux.intel.com, ricardo.martinez@linux.intel.com,
loic.poulain@linaro.org, ryazanov.s.a@gmail.com,
johannes@sipsolutions.net, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Jinjian Song <jinjian.song@fibocom.com>
Subject: Re: [net-next v1] net: wwan: t7xx: Add debug port
Date: Fri, 14 Jun 2024 08:11:36 -0700 [thread overview]
Message-ID: <20240614081136.17dd3d1f@kernel.org> (raw)
In-Reply-To: <MEYP282MB269762C5070B97CD769C8CD5BBC22@MEYP282MB2697.AUSP282.PROD.OUTLOOK.COM>
On Fri, 14 Jun 2024 17:49:51 +0800 Vanillan Wang wrote:
> From: Jinjian Song <jinjian.song@fibocom.com>
>
> Add support for userspace to switch on the debug port(ADB,MIPC).
> - ADB port: /dev/ccci_sap_adb
> - MIPC port: /dev/ttyMIPC0
>
> Switch on debug port:
> - debug: 'echo debug > /sys/bus/pci/devices/${bdf}/t7xx_mode
>
> Switch off debug port:
> - normal: 'echo normal > /sys/bus/pci/devices/${bdf}/t7xx_mode
You need to provide more detail on what it does and how it's used.
> + txq_mtu = t7xx_get_port_mtu(port);
> + if (txq_mtu < 0)
> + return -EINVAL;
drivers/net/wwan/t7xx/t7xx_port_debug.c:153:5-12: WARNING: Unsigned expression compared with zero: txq_mtu < 0
--
pw-bot: cr
next prev parent reply other threads:[~2024-06-14 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 9:49 [net-next v1] net: wwan: t7xx: Add debug port Vanillan Wang
2024-06-14 15:11 ` Jakub Kicinski [this message]
2024-06-19 10:08 ` Jinjian Song
2024-06-15 1:46 ` Sergey Ryazanov
2024-06-19 10:23 ` Jinjian Song
2024-06-19 19:43 ` Sergey Ryazanov
2024-06-17 1:04 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614081136.17dd3d1f@kernel.org \
--to=kuba@kernel.org \
--cc=chandrashekar.devegowda@intel.com \
--cc=chiranjeevi.rapolu@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haijun.liu@mediatek.com \
--cc=jinjian.song@fibocom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ricardo.martinez@linux.intel.com \
--cc=ryazanov.s.a@gmail.com \
--cc=songjinjian@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).