From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F88516C691; Fri, 14 Jun 2024 15:11:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718377898; cv=none; b=nzBCjArguBD5n+MN9YpQhXUFStLvjXX+kcPdYA6i4hJvzgUbi377xrQnS9lb9hYqwzB5mroiEsk4BBVU1PoPB+KUW/Ukw6JOTtzfkZqSm85pBateqaQsClcmRMTqDNQ7HpWrqMSF8N8ihF/AKsiTJDHwWtajo9s//Nn9eo7j+/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718377898; c=relaxed/simple; bh=We2wVbvGIh4SiL1lFpPuabgIOA7n4JXD4LEC9WjQBUw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ce2g1fQV4tAHhGEAJjHW/Hnt3HPL7GjR5hTMwDUbEe1u0OtrVFRVXmcg4Jj8UO1IUiDv50VvCj68pZfzpshDJdtIYcfjI8wpD8/YaprcAYifdARSeG5tsVzh99JKdmNKeO2SN+A7iLqW+wpl+PofxvKqmV5eWHKTpEuNFtIFlD0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BmTn2Hs+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BmTn2Hs+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14E93C2BD10; Fri, 14 Jun 2024 15:11:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718377897; bh=We2wVbvGIh4SiL1lFpPuabgIOA7n4JXD4LEC9WjQBUw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BmTn2Hs+c46ZxbfdiPMiwreMne48EC6AiOqx1IfDnHtzGmZtj/smkaPrg18MSJ6HU CcWtuoA25JBt3pphcW5bblZfdauVBpVxkF53gHSI3yOacGXrSahk8kExBoljnRMnEs AmcO6wzURqiw0/FOmiWhzJXr4KuwRWwbD2Zk6Yc6Jk+PbHQTuC4CjJnO18hdmTTDVf f7PY65xD1riQdw0/I7r61xOWJtfSLyToyvEXhS0+tFcMl/htuPktOAv6Arm5bcg1WT kpYVextxMbIqAsHApM5JIdlHnHXDAWCU7JnP3rA/zIY1kbQIILQi1ap2RTrYP/oBOe 9VI2g+jbpOodQ== Date: Fri, 14 Jun 2024 08:11:36 -0700 From: Jakub Kicinski To: Vanillan Wang Cc: chandrashekar.devegowda@intel.com, chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com, m.chetan.kumar@linux.intel.com, ricardo.martinez@linux.intel.com, loic.poulain@linaro.org, ryazanov.s.a@gmail.com, johannes@sipsolutions.net, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jinjian Song Subject: Re: [net-next v1] net: wwan: t7xx: Add debug port Message-ID: <20240614081136.17dd3d1f@kernel.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 14 Jun 2024 17:49:51 +0800 Vanillan Wang wrote: > From: Jinjian Song > > Add support for userspace to switch on the debug port(ADB,MIPC). > - ADB port: /dev/ccci_sap_adb > - MIPC port: /dev/ttyMIPC0 > > Switch on debug port: > - debug: 'echo debug > /sys/bus/pci/devices/${bdf}/t7xx_mode > > Switch off debug port: > - normal: 'echo normal > /sys/bus/pci/devices/${bdf}/t7xx_mode You need to provide more detail on what it does and how it's used. > + txq_mtu = t7xx_get_port_mtu(port); > + if (txq_mtu < 0) > + return -EINVAL; drivers/net/wwan/t7xx/t7xx_port_debug.c:153:5-12: WARNING: Unsigned expression compared with zero: txq_mtu < 0 -- pw-bot: cr