From: Jakub Kicinski <kuba@kernel.org>
To: Anil Samal <anil.samal@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
leszek.pepiak@intel.com, przemyslaw.kitszel@intel.com,
lukasz.czapnik@intel.com, anthony.l.nguyen@intel.com,
Simon Horman <horms@kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [PATCH iwl-next v3 3/3] ice: Implement driver functionality to dump serdes equalizer values
Date: Fri, 14 Jun 2024 17:55:59 -0700 [thread overview]
Message-ID: <20240614175559.4826e4aa@kernel.org> (raw)
In-Reply-To: <20240614125935.900102-4-anil.samal@intel.com>
On Fri, 14 Jun 2024 05:58:17 -0700 Anil Samal wrote:
> To debug link issues in the field, serdes Tx/Rx equalizer values
> help to determine the health of serdes lane.
>
> Extend 'ethtool -d' option to dump serdes Tx/Rx equalizer.
> The following list of equalizer param is supported
> a. rx_equalization_pre2
> b. rx_equalization_pre1
> c. rx_equalization_post1
> d. rx_equalization_bflf
> e. rx_equalization_bfhf
> f. rx_equalization_drate
> g. tx_equalization_pre1
> h. tx_equalization_pre3
> i. tx_equalization_atten
> j. tx_equalization_post1
> k. tx_equalization_pre2
I'd be tempted to create a dedicated way to dump vendor specific signal
quality indicators (both for Ethernet and PCIe). Feels little cleaner
than appending to a flat mixed-purpose dump. But either way is fine by
me, TBH. Much better than vendor tools poking into the BAR...
next prev parent reply other threads:[~2024-06-15 0:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 12:58 [PATCH iwl-next v3 0/3] ice:Support to dump PHY config, FEC Anil Samal
2024-06-14 12:58 ` [PATCH iwl-next v3 1/3] ice: Extend Sideband Queue command to support flags Anil Samal
2024-06-24 16:24 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-06-14 12:58 ` [PATCH iwl-next v3 2/3] ice: Implement driver functionality to dump fec statistics Anil Samal
2024-06-24 16:26 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-06-14 12:58 ` [PATCH iwl-next v3 3/3] ice: Implement driver functionality to dump serdes equalizer values Anil Samal
2024-06-15 0:55 ` Jakub Kicinski [this message]
2024-06-17 14:52 ` Simon Horman
2024-06-22 5:28 ` Samal, Anil
2024-06-25 2:35 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
-- strict thread matches above, loose matches on Subject: below --
2024-05-24 13:51 [PATCH iwl-next v3 0/3] ice:Support to dump PHY config, FEC Anil Samal
2024-05-24 13:51 ` [PATCH iwl-next v3 3/3] ice: Implement driver functionality to dump serdes equalizer values Anil Samal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614175559.4826e4aa@kernel.org \
--to=kuba@kernel.org \
--cc=anil.samal@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=leszek.pepiak@intel.com \
--cc=lukasz.czapnik@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).