From: Simon Horman <horms@kernel.org>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Jianbo Liu <jianbol@nvidia.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH ipsec] xfrm: Fix unregister netdevice hang on hardware offload.
Date: Fri, 14 Jun 2024 19:21:39 +0100 [thread overview]
Message-ID: <20240614182139.GW8447@kernel.org> (raw)
In-Reply-To: <ZmlmTTYL6AkBel4P@gauss3.secunet.de>
On Wed, Jun 12, 2024 at 11:11:41AM +0200, Steffen Klassert wrote:
> When offloading xfrm states to hardware, the offloading
> device is attached to the skbs secpath. If a skb is free
> is deffered, an unregister netdevice hangs because the
Hi Steffen,
Some minor nits from my side as it looks like there will be a v2 anyway.
deffered -> deferred
Flagged by checkpatch.pl --codespell
> netdevice is still refcounted.
>
> Fix this by removing the netdevice from the xfrm states
> when the netdevice is unregisterd. To find all xfrm states
nit: unregistered
> that need to be cleared we add another list where skbs
> linked to that are unlinked from the lists (deleted)
> but not yet freed.
>
> Fixes: d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API")
> Tested-by: Jianbo Liu <jianbol@nvidia.com>
> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
...
prev parent reply other threads:[~2024-06-14 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 9:11 [PATCH ipsec] xfrm: Fix unregister netdevice hang on hardware offload Steffen Klassert
2024-06-12 13:30 ` kernel test robot
2024-06-12 14:38 ` kernel test robot
2024-06-14 18:21 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614182139.GW8447@kernel.org \
--to=horms@kernel.org \
--cc=edumazet@google.com \
--cc=jianbol@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).