From: Jakub Kicinski <kuba@kernel.org>
To: "Csókás Bence" <csokas.bence@prolan.hu>
Cc: Frank Li <Frank.Li@freescale.com>,
"David S. Miller" <davem@davemloft.net>, <imx@lists.linux.dev>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH resubmit 2] net: fec: Fix FEC_ECR_EN1588 being cleared on link-down
Date: Fri, 14 Jun 2024 18:27:31 -0700 [thread overview]
Message-ID: <20240614182731.3244deef@kernel.org> (raw)
In-Reply-To: <0f315501-e8cb-4904-8c43-d9721fdef846@prolan.hu>
On Fri, 14 Jun 2024 09:59:16 +0200 Csókás Bence wrote:
> It only writes 0 if WOL is disabled AND the device has the MULTI_QUEUES
> quirk. Otherwise, we either write FEC_ECR_RESET, which resets the device
> (and the HW changes ECNTRL to its reset value), OR we RMW set the WOL
> sleep bits. And then, if some more quirks are set, we set ETHEREN.
>
> So I think RMW is the safest route here, instead of trying to keep track
> of all these different branches, re-read ECNTRL after reset etc.
Okay, just resend without the empty line between tags then.
prev parent reply other threads:[~2024-06-15 1:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 8:04 [PATCH resubmit 2] net: fec: Fix FEC_ECR_EN1588 being cleared on link-down Csókás, Bence
2024-06-12 19:16 ` Andrew Lunn
2024-06-13 15:12 ` Jakub Kicinski
2024-06-14 7:59 ` Csókás Bence
2024-06-15 1:27 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614182731.3244deef@kernel.org \
--to=kuba@kernel.org \
--cc=Frank.Li@freescale.com \
--cc=csokas.bence@prolan.hu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).