From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05C781B949 for ; Mon, 17 Jun 2024 16:16:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718640996; cv=none; b=stvGXngID5aAjR0wm/kvv9Ci86ow3zwZzFke6yYwTsR46Y6mDdZOuWqG1OPy2LGrc1QicQtKRdmNqBpDwNyspT0f51am9DA3BeLDONYW9iIaTWibe7RfQxeDKjwA2ZgqK7NL/CJzYbDQyLfg0WWogzG4pK/SJp6wOyaEJnIyjQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718640996; c=relaxed/simple; bh=+wbrMXHI1K3udEIdhQFfHU1ul3eAvVPemeTSl10tqzA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gVWVCqsmRJ9kJ9CkZtwe2EUeKcahSmS9e8u5rmm/mRO1hnEAkNUiXXPmrDc9gbkHHUetER79SmabHGEW0d7Midz4N54n0xTL8ASGhJLqflp+jF5e6vZhMxxf8kpyfBG5ZxeGYPWlFP6ghN3re0jrzOvhwPJ9rtrLuls2lO4hU1o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JIBJZSWt; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JIBJZSWt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718640994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=POQUo9ZYFx2TRBMxz/20fM6AHmLGnv+tvZ6Yfe8E564=; b=JIBJZSWtM4sX+oh07ckZUbvRYNGDy7m5K0pxdk7aWSAVJJkLReejtMefeJB7nI0a/OZn8n HNYjzMsNrvWwJipJqzjWGNWZVJutZo/sn+vVpRGnPtSIyuh5D74pSlzHTFVH7aECFy022s VqaYLbEZcphmvgkccdTJCGBlhqvNV0c= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-620-FBYYCV08M0SL06ixJ7bcYA-1; Mon, 17 Jun 2024 12:16:32 -0400 X-MC-Unique: FBYYCV08M0SL06ixJ7bcYA-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2ebe4b327a6so34286031fa.3 for ; Mon, 17 Jun 2024 09:16:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718640991; x=1719245791; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=POQUo9ZYFx2TRBMxz/20fM6AHmLGnv+tvZ6Yfe8E564=; b=i3iAk791+PTPtl5erui9UTyFSg8est74274pi7UxWuXPgd+fkEtP402kejaC8/v0OP Qv8nm22t4WRp0S8xD5aymAwPcp8Mv4BSpZTHvFlSW74hirxdnzld2hiiYMuiQYYjpE+I /qpTpH7EGLcIGK2aHAWGZWtijCLOIS4Sz70rbAowpb0aOblFIYar6+PR51xeR5O6R1kS 1n5GQP6HeZTE7uFLen6IGN7fFLK74CD32ZJYRIOpYcJ1FW9h1WOEiNptNqmF0xrAmeoL t6tU/0XHPamUVSIhjdWEa/NXw8kCES6rsj54xqBdQKBNRv6wJ1W7yMcOviyO7MNxcfaV ZOaw== X-Forwarded-Encrypted: i=1; AJvYcCU/X547kr7kB6NxW6VvVQa8ollo++eZc6ogHCeIHhX+tVn7Zbz1gIypdULr6MQTliEtyi+NA4ecl4/MhVQ3n02NQgJCnOSE X-Gm-Message-State: AOJu0Yw4l8/wN7nUWb6jZ2P9DumqUwAYQZth8jT/6m1ENGXlRAPVRX1r ETfdGkkeWfsy3taIWa0wjhHwoxEPqfWG0v5PVqkax8tTJsvuEw1fLVAFEyA649VZ8hjvQEpZynw m4yZHhWmMEF8EbVm3Nk7cq43Ney6Noi7g++LyrNRlKiHe+e1Q1n2Zkg== X-Received: by 2002:a2e:b60e:0:b0:2eb:3281:5655 with SMTP id 38308e7fff4ca-2ec0e5d13c2mr73095841fa.26.1718640990984; Mon, 17 Jun 2024 09:16:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IENS3KQDOp3objS9rqmf8lxn0GTyDBxVOhps/4Ykbq3BO9fpHje+C9/neMWBdUOIIrAR/h3uA== X-Received: by 2002:a2e:b60e:0:b0:2eb:3281:5655 with SMTP id 38308e7fff4ca-2ec0e5d13c2mr73095621fa.26.1718640990425; Mon, 17 Jun 2024 09:16:30 -0700 (PDT) Received: from redhat.com ([2a02:14f:17c:d4a1:48dc:2f16:ab1d:e55a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ec25647ec2sm7042141fa.56.2024.06.17.09.16.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 09:16:29 -0700 (PDT) Date: Mon, 17 Jun 2024 12:16:24 -0400 From: "Michael S. Tsirkin" To: Jiri Pirko Cc: Jason Wang , Jason Xing , Heng Qi , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, xuanzhuo@linux.alibaba.com, virtualization@lists.linux.dev, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, netdev@vger.kernel.org Subject: Re: [patch net-next] virtio_net: add support for Byte Queue Limits Message-ID: <20240617121448-mutt-send-email-mst@kernel.org> References: <20240607062231-mutt-send-email-mst@kernel.org> <20240610101346-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jun 17, 2024 at 11:30:36AM +0200, Jiri Pirko wrote: > Mon, Jun 17, 2024 at 03:44:55AM CEST, jasowang@redhat.com wrote: > >On Mon, Jun 10, 2024 at 10:19 PM Michael S. Tsirkin wrote: > >> > >> On Fri, Jun 07, 2024 at 01:30:34PM +0200, Jiri Pirko wrote: > >> > Fri, Jun 07, 2024 at 12:23:37PM CEST, mst@redhat.com wrote: > >> > >On Fri, Jun 07, 2024 at 11:57:37AM +0200, Jiri Pirko wrote: > >> > >> >True. Personally, I would like to just drop orphan mode. But I'm not > >> > >> >sure others are happy with this. > >> > >> > >> > >> How about to do it other way around. I will take a stab at sending patch > >> > >> removing it. If anyone is against and has solid data to prove orphan > >> > >> mode is needed, let them provide those. > >> > > > >> > >Break it with no warning and see if anyone complains? > >> > > >> > This is now what I suggested at all. > >> > > >> > >No, this is not how we handle userspace compatibility, normally. > >> > > >> > Sure. > >> > > >> > Again: > >> > > >> > I would send orphan removal patch containing: > >> > 1) no module options removal. Warn if someone sets it up > >> > 2) module option to disable napi is ignored > >> > 3) orphan mode is removed from code > >> > > >> > There is no breakage. Only, hypotetically performance downgrade in some > >> > hypotetical usecase nobody knows of. > >> > >> Performance is why people use virtio. It's as much a breakage as any > >> other bug. The main difference is, with other types of breakage, they > >> are typically binary and we can not tolerate them at all. A tiny, > >> negligeable performance regression might be tolarable if it brings > >> other benefits. I very much doubt avoiding interrupts is > >> negligeable though. And making code simpler isn't a big benefit, > >> users do not care. > > > >It's not just making code simpler. As discussed in the past, it also > >fixes real bugs. > > > >> > >> > My point was, if someone presents > >> > solid data to prove orphan is needed during the patch review, let's toss > >> > out the patch. > >> > > >> > Makes sense? > >> > >> It's not hypothetical - if anything, it's hypothetical that performance > >> does not regress. And we just got a report from users that see a > >> regression without. So, not really. > > > >Probably, but do we need to define a bar here? Looking at git history, > >we didn't ask a full benchmark for a lot of commits that may touch It's patently obvious that not getting interrupts is better than getting interrupts. The onus of proof would be on people who claim otherwise. > Moreover, there is no "benchmark" to run anyway, is it? > Tought. Talk to users that report regressions. > >performance. > > > >Thanks > > > >> > >> > > >> > > > >> > >-- > >> > >MST > >> > > > >> > >