From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9896B1BC43 for ; Mon, 17 Jun 2024 14:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718632896; cv=none; b=n3gMmPvFr8Fm7tSFmZaoKJp3TeudxU0pxYOV3xNp7vL/qtTgCsuSOvZA+FQAAWGq79qBcP2F9weObYAmxTVjG+9kPMaXs/GSJ/fQm0D4QXhVT2OM+ClHkGKp2DzNXFCRmM+3D9z3J+83upi36GjTk3qp67Bmolw7trvGwvkMF9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718632896; c=relaxed/simple; bh=ZSTtpCZOHnxjZs6PTQF1g7rTOoGh1x9yJulQj1I5kaI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eefX+pdGjsJSHhmzP1ZYCMK+LhYbwXfiFknTV7opTVFVXmjLDMNcuj+LynY2oTsTBNIpqNA62SEZxb7VOmv1dn1hf7uxo4WPbgAHyUEfp0dLtXu7k605r7ZoD4KxaUeByTUmPBF+TRZe/RBVrpSe89JFIyFQDZYuZCsGfEGAge4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ClXaVSFw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ClXaVSFw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21EBDC2BD10; Mon, 17 Jun 2024 14:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718632896; bh=ZSTtpCZOHnxjZs6PTQF1g7rTOoGh1x9yJulQj1I5kaI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ClXaVSFwFP7ZVVO8UtNNj7LEODi+6OKSidaaCQRIubS3jSz8JIMZP46ZVITX3O8ik KwGfFy5geGZ1YMj+hU5xL//UTdI7TCDepgIfKyCo5ydbokYMvnqpF3i7cI3tuOk/6B b39DzeuyIDyt7Is0YqngA4U8y6DQi/uZlFfGQC/RRblnP/ul236XWu6TXpWZJ/R4bl inFyd52cmhN+3kT8aAGFua7HcCcZmu2a8vJCpHhCtpweYlJoUu2ipEMEd3VOLpl96X ZT80t8pbCT2FAbhCrPv2lJklQUON+v4dDilY7rBj8iW9P14N/XsWXA+DnF8l7egLjP 1XRCz8hjXCoKw== Date: Mon, 17 Jun 2024 15:01:33 +0100 From: Simon Horman To: Marcin Szycik Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Piotr Gardocki , Ahmed Zaki , Przemek Kitszel Subject: Re: [PATCH iwl-next] ice: Distinguish driver reset and removal for AQ shutdown Message-ID: <20240617140133.GT8447@kernel.org> References: <20240614103811.1178779-1-marcin.szycik@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240614103811.1178779-1-marcin.szycik@linux.intel.com> On Fri, Jun 14, 2024 at 12:38:11PM +0200, Marcin Szycik wrote: > From: Piotr Gardocki > > Admin queue command for shutdown AQ contains a flag to indicate driver > unload. However, the flag is always set in the driver, even for resets. It > can cause the firmware to consider driver as unloaded once the PF reset is > triggered on all ports of device, which could lead to unexpected results. > > Add an additional function parameter to functions that shutdown AQ, > indicating whether the driver is actually unloading. > > Reviewed-by: Ahmed Zaki > Reviewed-by: Przemek Kitszel > Signed-off-by: Piotr Gardocki > Signed-off-by: Marcin Szycik Reviewed-by: Simon Horman