From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CC5F16191B for ; Mon, 17 Jun 2024 18:48:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718650127; cv=none; b=VlZ3MBBM4BAMwIw+9P6JoSgP0jrJ60SMXvfCCYA8ncH6jkH4jG37wgSQa6Vc6QaNLlvK1BNUB1Ryo63QSdL0DSzEIaEfQQXIpMSmwQBio/kyZvZFCE+8rdOFYUjPrJzQACDVmewaH8qbleUvajI2+duklZm4ZRYAn/5ZSwmPltw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718650127; c=relaxed/simple; bh=2pW5K756b3vnOMMzbNNarIqr13h/Yp4f80y1nx+hSeA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sUJTIwNxC5F1vMaBKueCcYwcYNxkHsygY1h6g90fgm4adH2Xv5tm990MPbTMaaHFFyhhk5lOvOVLtyc02IijFFzqlfgO/WDJfJtAPqk07XQoQh0tpsLqfOWC059Mj5uNeHFbh85gh6PEOAfJ0bdjZRzG0wmDa6LcYnsTcPjOSm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QQHHHvNf; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QQHHHvNf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718650124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZZaXnpTdtezaPILoSmIEc1ZZ9gp2RX1pMrPgPH0P1ko=; b=QQHHHvNfVyQOhnbnt1++JzugD5pRY884A6Y3GMiPWK4Ipa4lXJsqG8Dp7nxu3lCuiXdkWG 6Xx32+lMeNUJMAxT5yoQCIDH8jD4BRgcP4f5EYQ0moqYg5JB5Ln6GS+kasWz0Oq49uu2wP hVMlVc3UVqq1+k//Ud1UZuSk7byLtk8= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-zWcbT9eYNueXPuISU60Zsg-1; Mon, 17 Jun 2024 14:48:43 -0400 X-MC-Unique: zWcbT9eYNueXPuISU60Zsg-1 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-627f20cff42so91075757b3.0 for ; Mon, 17 Jun 2024 11:48:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718650122; x=1719254922; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZZaXnpTdtezaPILoSmIEc1ZZ9gp2RX1pMrPgPH0P1ko=; b=uxOoXHp6obwiu8to6uN+aDH/qfYhf1pApWMCh3/AqkUg1agch4AUGtE+fHNI0kR6o/ PJuBcfCGnql090SW3cv9p1ss26+j93xLkr2u2Wt+TTX6O9CzpEwZPJ+9K6msFJKETQtZ 2oATy1epKRKjQsPXDjigIjN4pLUD3jhX2RE0b8Wlt/dfgw5nmzH4rnica4sKLWrl1JT7 5cwnm8Hrug//Nv/eF7PP0sWgRUzF75rEFhlK1EsltcRh3E+FT6ratBixtfYJcWW8qHbw lGVcCOlNiPnN+bbyS3FGpXDeG4ZnkMZRq5htBz4HPUYyHyww/K6l4lX0ss0FEy4EbqGX wrLQ== X-Gm-Message-State: AOJu0Yzsl/zWy/QOEY38kM89Zz+3zi7o1oKjgfSA4Dtt5cIUIx6Ehhov IEUXHaJfC6GWychjPCnfSAcf4c8TLI5q7n93TtmgJRE0s89cJ8wFsLvpglr9RzgSjNVk3gmYtKg tqrJbxScTdpJZ5D1FBGRgv5Wszrbav1iAu8Ha9605AgCFRo+0VYkcxg== X-Received: by 2002:a81:9245:0:b0:617:d8a7:df60 with SMTP id 00721157ae682-6394a6c537dmr4984637b3.40.1718650122521; Mon, 17 Jun 2024 11:48:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFD/nY/QKBHmtUF5IvBSZOGzxA0YnpE8P+v9PhV468bowcK1HtPww2hkYffchrQU0zOplnI7Q== X-Received: by 2002:a81:9245:0:b0:617:d8a7:df60 with SMTP id 00721157ae682-6394a6c537dmr4984307b3.40.1718650121979; Mon, 17 Jun 2024 11:48:41 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b2a5f10739sm57649316d6.146.2024.06.17.11.48.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2024 11:48:41 -0700 (PDT) Date: Mon, 17 Jun 2024 20:48:04 +0200 From: Stefano Brivio To: Aaron Conole Cc: netdev@vger.kernel.org, dev@openvswitch.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Pravin B Shelar , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , =?UTF-8?B?QWRy?= =?UTF-8?B?acOhbg==?= Moreno , Simon Horman Subject: Re: [PATCH net-next 6/7] selftests: net: Use the provided dpctl rather than the vswitchd for tests. Message-ID: <20240617204804.680a1254@elisabeth> In-Reply-To: <20240617180218.1154326-7-aconole@redhat.com> References: <20240617180218.1154326-1-aconole@redhat.com> <20240617180218.1154326-7-aconole@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 17 Jun 2024 14:02:17 -0400 Aaron Conole wrote: > The current pmtu test infrastucture requires an installed copy of the > ovs-vswitchd userspace. This means that any automated or constrained > environments may not have the requisite tools to run the tests. However, > the pmtu tests don't require any special classifier processing. Indeed > they are only using the vswitchd in the most basic mode - as a NORMAL > switch. > > However, the ovs-dpctl kernel utility can now program all the needed basic > flows to allow traffic to traverse the tunnels and provide support for at > least testing some basic pmtu scenarios. More complicated flow pipelines > can be added to the internal ovs test infrastructure, but that is work for > the future. For now, enable the most common cases - wide mega flows with > no other prerequisites. > > Enhance the pmtu testing to try testing using the internal utility, first. > As a fallback, if the internal utility isn't running, then try with the > ovs-vswitchd userspace tools. Oh, nice, it looks saner than I thought. :) > Signed-off-by: Aaron Conole > --- > tools/testing/selftests/net/pmtu.sh | 145 +++++++++++++++++++++++----- > 1 file changed, 123 insertions(+), 22 deletions(-) Reviewed-by: Stefano Brivio -- Stefano