From: Jakub Kicinski <kuba@kernel.org>
To: FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, horms@kernel.org,
jiri@resnulli.us, pabeni@redhat.com, linux@armlinux.org.uk,
hfdevel@gmx.net, naveenm@marvell.com, jdamato@fastly.com
Subject: Re: [PATCH net-next v11 4/7] net: tn40xx: add basic Tx handling
Date: Tue, 18 Jun 2024 18:50:00 -0700 [thread overview]
Message-ID: <20240618185000.1ecc561f@kernel.org> (raw)
In-Reply-To: <20240618051608.95208-5-fujita.tomonori@gmail.com>
On Tue, 18 Jun 2024 14:16:05 +0900 FUJITA Tomonori wrote:
> + * As our benchmarks shows, it adds 1.5 Gbit/sec to NIS's throughput.
nit: NIC's
> +static int tn40_start_xmit(struct sk_buff *skb, struct net_device *ndev)
return type should be netdev_tx_t ?
> + netif_trans_update(ndev);
I don't think you need to call this, core sets the trans time
all by itself
> +static void tn40_link_changed(struct tn40_priv *priv)
> +{
> + u32 link = tn40_read_reg(priv,
> + TN40_REG_MAC_LNK_STAT) & TN40_MAC_LINK_STAT;
> +
> + netdev_dbg(priv->ndev, "link changed %u\n", link);
shouldn't this call netif_carrier_on / off?
> + mdelay(100);
there are 3 more mdelays in the driver, all seem like candidates for
being msleep
next prev parent reply other threads:[~2024-06-19 1:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 5:16 [PATCH net-next v11 0/7] add ethernet driver for Tehuti Networks TN40xx chips FUJITA Tomonori
2024-06-18 5:16 ` [PATCH net-next v11 1/7] PCI: Add Edimax Vendor ID to pci_ids.h FUJITA Tomonori
2024-06-18 5:16 ` [PATCH net-next v11 2/7] net: tn40xx: add pci driver for Tehuti Networks TN40xx chips FUJITA Tomonori
2024-06-18 5:16 ` [PATCH net-next v11 3/7] net: tn40xx: add register defines FUJITA Tomonori
2024-06-18 5:16 ` [PATCH net-next v11 4/7] net: tn40xx: add basic Tx handling FUJITA Tomonori
2024-06-19 1:50 ` Jakub Kicinski [this message]
2024-06-19 3:44 ` FUJITA Tomonori
2024-06-19 14:55 ` Jakub Kicinski
2024-06-19 23:49 ` FUJITA Tomonori
2024-06-18 5:16 ` [PATCH net-next v11 5/7] net: tn40xx: add basic Rx handling FUJITA Tomonori
2024-06-19 1:52 ` Jakub Kicinski
2024-06-19 4:03 ` FUJITA Tomonori
2024-06-19 1:52 ` Jakub Kicinski
2024-06-19 6:21 ` FUJITA Tomonori
2024-06-18 5:16 ` [PATCH net-next v11 6/7] net: tn40xx: add mdio bus support FUJITA Tomonori
2024-06-18 5:16 ` [PATCH net-next v11 7/7] net: tn40xx: add phylink support FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618185000.1ecc561f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=fujita.tomonori@gmail.com \
--cc=hfdevel@gmx.net \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=jiri@resnulli.us \
--cc=linux@armlinux.org.uk \
--cc=naveenm@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).