* Re: [PATCH net] selftests: virtio_net: add forgotten config options
2024-06-19 6:17 [PATCH net] selftests: virtio_net: add forgotten config options Jiri Pirko
@ 2024-06-19 7:14 ` Xuan Zhuo
2024-06-19 7:33 ` Michael S. Tsirkin
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Xuan Zhuo @ 2024-06-19 7:14 UTC (permalink / raw)
To: Jiri Pirko
Cc: kuba, matttbe, mst, jasowang, eperezma, shuah, petrm, pabeni,
linux-kselftest, virtualization, netdev
On Wed, 19 Jun 2024 08:17:48 +0200, Jiri Pirko <jiri@resnulli.us> wrote:
> From: Jiri Pirko <jiri@nvidia.com>
>
> One may use tools/testing/selftests/drivers/net/virtio_net/config
> for example for vng build command like this one:
> $ vng -v -b -f tools/testing/selftests/drivers/net/virtio_net/config
>
> In that case, the needed kernel config options are not turned on.
> Add the missed kernel config options.
>
> Reported-by: Jakub Kicinski <kuba@kernel.org>
> Closes: https://lore.kernel.org/netdev/20240617072614.75fe79e7@kernel.org/
> Reported-by: Matthieu Baerts <matttbe@kernel.org>
> Closes: https://lore.kernel.org/netdev/1a63f209-b1d4-4809-bc30-295a5cafa296@kernel.org/
> Fixes: ccfaed04db5e ("selftests: virtio_net: add initial tests")
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> ---
> tools/testing/selftests/drivers/net/virtio_net/config | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/testing/selftests/drivers/net/virtio_net/config b/tools/testing/selftests/drivers/net/virtio_net/config
> index f35de0542b60..040b600d52f1 100644
> --- a/tools/testing/selftests/drivers/net/virtio_net/config
> +++ b/tools/testing/selftests/drivers/net/virtio_net/config
> @@ -1,2 +1,8 @@
> CONFIG_VIRTIO_NET=y
> CONFIG_VIRTIO_DEBUG=y
> +CONFIG_NET_L3_MASTER_DEV=y
> +CONFIG_IPV6_MULTIPLE_TABLES=y
> +CONFIG_NET_VRF=m
> +CONFIG_BPF_SYSCALL=y
> +CONFIG_CGROUP_BPF=y
> +CONFIG_IPV6=y
> --
> 2.45.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net] selftests: virtio_net: add forgotten config options
2024-06-19 6:17 [PATCH net] selftests: virtio_net: add forgotten config options Jiri Pirko
2024-06-19 7:14 ` Xuan Zhuo
@ 2024-06-19 7:33 ` Michael S. Tsirkin
2024-06-20 14:11 ` Jakub Kicinski
2024-06-20 14:20 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2024-06-19 7:33 UTC (permalink / raw)
To: Jiri Pirko
Cc: netdev, kuba, matttbe, jasowang, xuanzhuo, eperezma, shuah, petrm,
pabeni, linux-kselftest, virtualization
On Wed, Jun 19, 2024 at 08:17:48AM +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@nvidia.com>
>
> One may use tools/testing/selftests/drivers/net/virtio_net/config
> for example for vng build command like this one:
> $ vng -v -b -f tools/testing/selftests/drivers/net/virtio_net/config
>
> In that case, the needed kernel config options are not turned on.
> Add the missed kernel config options.
>
> Reported-by: Jakub Kicinski <kuba@kernel.org>
> Closes: https://lore.kernel.org/netdev/20240617072614.75fe79e7@kernel.org/
> Reported-by: Matthieu Baerts <matttbe@kernel.org>
> Closes: https://lore.kernel.org/netdev/1a63f209-b1d4-4809-bc30-295a5cafa296@kernel.org/
> Fixes: ccfaed04db5e ("selftests: virtio_net: add initial tests")
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> tools/testing/selftests/drivers/net/virtio_net/config | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/testing/selftests/drivers/net/virtio_net/config b/tools/testing/selftests/drivers/net/virtio_net/config
> index f35de0542b60..040b600d52f1 100644
> --- a/tools/testing/selftests/drivers/net/virtio_net/config
> +++ b/tools/testing/selftests/drivers/net/virtio_net/config
> @@ -1,2 +1,8 @@
> CONFIG_VIRTIO_NET=y
> CONFIG_VIRTIO_DEBUG=y
> +CONFIG_NET_L3_MASTER_DEV=y
> +CONFIG_IPV6_MULTIPLE_TABLES=y
> +CONFIG_NET_VRF=m
> +CONFIG_BPF_SYSCALL=y
> +CONFIG_CGROUP_BPF=y
> +CONFIG_IPV6=y
> --
> 2.45.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net] selftests: virtio_net: add forgotten config options
2024-06-19 6:17 [PATCH net] selftests: virtio_net: add forgotten config options Jiri Pirko
2024-06-19 7:14 ` Xuan Zhuo
2024-06-19 7:33 ` Michael S. Tsirkin
@ 2024-06-20 14:11 ` Jakub Kicinski
2024-06-20 14:20 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2024-06-20 14:11 UTC (permalink / raw)
To: Jiri Pirko
Cc: netdev, matttbe, mst, jasowang, xuanzhuo, eperezma, shuah, petrm,
pabeni, linux-kselftest, virtualization
On Wed, 19 Jun 2024 08:17:48 +0200 Jiri Pirko wrote:
> CONFIG_VIRTIO_NET=y
> CONFIG_VIRTIO_DEBUG=y
> +CONFIG_NET_L3_MASTER_DEV=y
> +CONFIG_IPV6_MULTIPLE_TABLES=y
> +CONFIG_NET_VRF=m
> +CONFIG_BPF_SYSCALL=y
> +CONFIG_CGROUP_BPF=y
> +CONFIG_IPV6=y
I sorted them alphabetically when applying, hope you don't mind.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net] selftests: virtio_net: add forgotten config options
2024-06-19 6:17 [PATCH net] selftests: virtio_net: add forgotten config options Jiri Pirko
` (2 preceding siblings ...)
2024-06-20 14:11 ` Jakub Kicinski
@ 2024-06-20 14:20 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-06-20 14:20 UTC (permalink / raw)
To: Jiri Pirko
Cc: netdev, kuba, matttbe, mst, jasowang, xuanzhuo, eperezma, shuah,
petrm, pabeni, linux-kselftest, virtualization
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 19 Jun 2024 08:17:48 +0200 you wrote:
> From: Jiri Pirko <jiri@nvidia.com>
>
> One may use tools/testing/selftests/drivers/net/virtio_net/config
> for example for vng build command like this one:
> $ vng -v -b -f tools/testing/selftests/drivers/net/virtio_net/config
>
> In that case, the needed kernel config options are not turned on.
> Add the missed kernel config options.
>
> [...]
Here is the summary with links:
- [net] selftests: virtio_net: add forgotten config options
https://git.kernel.org/netdev/net/c/48dea8f7bb01
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread