From: "Michael S. Tsirkin" <mst@redhat.com>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: netdev@vger.kernel.org, virtualization@lists.linux.dev,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>
Subject: Re: [PATCH net-next v4 2/5] virtio_net: enable irq for the control vq
Date: Wed, 19 Jun 2024 17:19:12 -0400 [thread overview]
Message-ID: <20240619171708-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20240619161908.82348-3-hengqi@linux.alibaba.com>
On Thu, Jun 20, 2024 at 12:19:05AM +0800, Heng Qi wrote:
> @@ -5312,7 +5315,7 @@ static int virtnet_find_vqs(struct virtnet_info *vi)
>
> /* Parameters for control virtqueue, if any */
> if (vi->has_cvq) {
> - callbacks[total_vqs - 1] = NULL;
> + callbacks[total_vqs - 1] = virtnet_cvq_done;
> names[total_vqs - 1] = "control";
> }
>
If the # of MSIX vectors is exactly for data path VQs,
this will cause irq sharing between VQs which will degrade
performance significantly.
So no, you can not just do it unconditionally.
The correct fix probably requires virtio core/API extensions.
--
MST
next prev parent reply other threads:[~2024-06-19 21:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 16:19 [PATCH net-next v4 0/5] virtio_net: enable the irq for ctrlq Heng Qi
2024-06-19 16:19 ` [PATCH net-next v4 1/5] virtio_net: passing control_buf explicitly Heng Qi
2024-06-19 16:19 ` [PATCH net-next v4 2/5] virtio_net: enable irq for the control vq Heng Qi
2024-06-19 21:19 ` Michael S. Tsirkin [this message]
2024-06-20 7:29 ` Heng Qi
2024-06-20 8:21 ` Jason Wang
2024-06-20 8:26 ` Jason Wang
2024-06-20 9:53 ` Heng Qi
2024-06-20 10:10 ` Michael S. Tsirkin
2024-06-20 10:11 ` Michael S. Tsirkin
2024-06-20 10:31 ` Heng Qi
2024-06-26 7:52 ` Jiri Pirko
2024-06-26 8:08 ` Michael S. Tsirkin
2024-06-26 8:43 ` Jiri Pirko
2024-06-26 9:58 ` Michael S. Tsirkin
2024-06-26 11:51 ` Jiri Pirko
2024-07-08 11:40 ` Jiri Pirko
2024-07-08 12:19 ` Heng Qi
2024-06-21 7:41 ` Xuan Zhuo
2024-06-21 11:46 ` Michael S. Tsirkin
2024-06-25 1:27 ` Jason Wang
2024-06-25 7:14 ` Michael S. Tsirkin
2024-06-20 8:32 ` Michael S. Tsirkin
2024-06-20 8:37 ` Jason Wang
2024-06-20 9:38 ` Heng Qi
2024-06-20 10:07 ` Michael S. Tsirkin
2024-06-24 11:30 ` Michael S. Tsirkin
2024-06-19 16:19 ` [PATCH net-next v4 3/5] virtio_net: change the command token to completion Heng Qi
2024-06-19 16:19 ` [PATCH net-next v4 4/5] virtio_net: refactor command sending and response handling Heng Qi
2024-06-19 16:19 ` [PATCH net-next v4 5/5] virtio_net: improve dim command request efficiency Heng Qi
2024-06-20 6:40 ` kernel test robot
2024-06-19 21:16 ` [PATCH net-next v4 0/5] virtio_net: enable the irq for ctrlq Michael S. Tsirkin
2024-06-20 7:16 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619171708-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).