From: Simon Horman <horms@kernel.org>
To: Jon Kohler <jon@nutanix.com>
Cc: Christian Benvenuti <benve@cisco.com>,
Satish Kharat <satishkh@cisco.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] enic: add ethtool get_channel support
Date: Wed, 19 Jun 2024 19:01:05 +0100 [thread overview]
Message-ID: <20240619180105.GR690967@kernel.org> (raw)
In-Reply-To: <20240619175915.GQ690967@kernel.org>
On Wed, Jun 19, 2024 at 06:59:15PM +0100, Simon Horman wrote:
> On Tue, Jun 18, 2024 at 09:01:46AM -0700, Jon Kohler wrote:
> > Add .get_channel to enic_ethtool_ops to enable basic ethtool -l
> > support to get the current channel configuration.
>
> This is nice :)
>
> > Note that the driver does not support dynamically changing queue
> > configuration, so .set_channel is intentionally unused. Instead, users
> > should use Cisco's hardware management tools (UCSM/IMC) to modify
> > virtual interface card configuration out of band.
>
> That is a shame :(
>
> > Signed-off-by: Jon Kohler <jon@nutanix.com>
>
> Sad face aside, this looks good to me.
>
> Reviewed-by: Simon Horman <horms@kernel.org>
Oops, I failed to notice that Przemek Kitszel has some questions about this
regarding issues that I overlooked. So I'll have to take my tag back for now.
Sorry for the noise.
prev parent reply other threads:[~2024-06-19 18:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 16:01 [PATCH] enic: add ethtool get_channel support Jon Kohler
2024-06-18 16:20 ` Przemek Kitszel
2024-06-18 16:39 ` Jon Kohler
2024-06-20 0:04 ` Jakub Kicinski
2024-06-20 19:49 ` Jon Kohler
2024-06-20 19:58 ` Jakub Kicinski
2024-06-24 18:36 ` Jon Kohler
2024-06-19 17:59 ` Simon Horman
2024-06-19 18:01 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619180105.GR690967@kernel.org \
--to=horms@kernel.org \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jon@nutanix.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=satishkh@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).