From: Jakub Kicinski <kuba@kernel.org>
To: Adrian Moreno <amorenoz@redhat.com>
Cc: netdev@vger.kernel.org, aconole@redhat.com, echaudro@redhat.com,
horms@kernel.org, i.maximets@ovn.org, dev@openvswitch.org,
Donald Hunter <donald.hunter@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Pravin B Shelar <pshelar@ovn.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 05/10] net: openvswitch: add emit_sample action
Date: Wed, 19 Jun 2024 18:39:43 -0700 [thread overview]
Message-ID: <20240619183943.5a41f009@kernel.org> (raw)
In-Reply-To: <20240619210023.982698-6-amorenoz@redhat.com>
On Wed, 19 Jun 2024 23:00:06 +0200 Adrian Moreno wrote:
> + OVS_EMIT_SAMPLE_ATTR_UNPSEC,
Are you using this one? Looking closely I presume not, since it's
misspelled ;) You can assign = 1 to GROUP, no need to name the value
for 0.
> + OVS_EMIT_SAMPLE_ATTR_GROUP, /* u32 number. */
> + OVS_EMIT_SAMPLE_ATTR_COOKIE, /* Optional, user specified cookie. */
> + __OVS_EMIT_SAMPLE_ATTR_MAX
kdoc is complaining that __OVS_EMIT_SAMPLE_ATTR_MAX is not documented.
You can add:
/* private: */
before, take a look at include/uapi/linux/netdev.h for example.
--
pw-bot: cr
next prev parent reply other threads:[~2024-06-20 1:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 21:00 [PATCH net-next v3 00/10] net: openvswitch: Add sample multicasting Adrian Moreno
2024-06-19 21:00 ` [PATCH net-next v3 01/10] net: psample: add user cookie Adrian Moreno
2024-06-19 21:00 ` [PATCH net-next v3 02/10] net: sched: act_sample: add action cookie to sample Adrian Moreno
2024-06-19 21:00 ` [PATCH net-next v3 03/10] net: psample: skip packet copy if no listeners Adrian Moreno
2024-06-19 21:00 ` [PATCH net-next v3 04/10] net: psample: allow using rate as probability Adrian Moreno
2024-06-24 21:40 ` Ilya Maximets
2024-06-19 21:00 ` [PATCH net-next v3 05/10] net: openvswitch: add emit_sample action Adrian Moreno
2024-06-20 1:39 ` Jakub Kicinski [this message]
2024-06-20 7:29 ` Adrián Moreno
2024-06-19 21:00 ` [PATCH net-next v3 06/10] net: openvswitch: store sampling probability in cb Adrian Moreno
2024-06-19 21:00 ` [PATCH net-next v3 07/10] selftests: openvswitch: add emit_sample action Adrian Moreno
2024-06-19 21:00 ` [PATCH net-next v3 08/10] selftests: openvswitch: add userspace parsing Adrian Moreno
2024-06-19 21:00 ` [PATCH net-next v3 09/10] selftests: openvswitch: parse trunc action Adrian Moreno
2024-06-19 21:00 ` [PATCH net-next v3 10/10] selftests: openvswitch: add emit_sample test Adrian Moreno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619183943.5a41f009@kernel.org \
--to=kuba@kernel.org \
--cc=aconole@redhat.com \
--cc=amorenoz@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=donald.hunter@gmail.com \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).