From: Florian Westphal <fw@strlen.de>
To: Xin Long <lucien.xin@gmail.com>
Cc: Ilya Maximets <i.maximets@ovn.org>,
Florian Westphal <fw@strlen.de>,
network dev <netdev@vger.kernel.org>,
dev@openvswitch.org,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Davide Caratti <dcaratti@redhat.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Eric Dumazet <edumazet@google.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
kuba@kernel.org, Paolo Abeni <pabeni@redhat.com>,
davem@davemloft.net, Pablo Neira Ayuso <pablo@netfilter.org>,
Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH net-next 3/3] openvswitch: set IPS_CONFIRMED in tmpl status only when commit is set in conntrack
Date: Wed, 19 Jun 2024 22:19:59 +0200 [thread overview]
Message-ID: <20240619201959.GA1513@breakpoint.cc> (raw)
In-Reply-To: <CADvbK_dWpZd6RyqRdiHvWP9SrG1Otfi4h5Ae=yhErLc+DhLkaw@mail.gmail.com>
Xin Long <lucien.xin@gmail.com> wrote:
> > master connection only if it is not yet confirmed. Users may commit different
> > labels for the related connection. This should be more in line with the
> > previous behavior.
> >
> > What do you think?
> >
> You're right.
> Also, I noticed the related ct->mark is set to master ct->mark in
> init_conntrack() as well as secmark when creating the related ct.
>
> Hi, Florian,
>
> Any reason why the labels are not set to master ct's in there?
The intent was to have lables be set only via ctnetlink (userspace)
or ruleset.
The original use case was for tagging connections based on
observed behaviour/properties at a later time, not at start of flow.
next prev parent reply other threads:[~2024-06-19 20:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-16 21:09 [PATCH net-next 0/3] net: handle the exp removal problem with ovs upcall properly Xin Long
2023-07-16 21:09 ` [PATCH net-next 1/3] netfilter: allow exp not to be removed in nf_ct_find_expectation Xin Long
2023-07-19 16:07 ` Aaron Conole
2023-07-16 21:09 ` [PATCH net-next 2/3] net: sched: set IPS_CONFIRMED in tmpl status only when commit is set in act_ct Xin Long
2023-07-19 16:07 ` Aaron Conole
2023-07-19 16:44 ` Davide Caratti
2023-07-16 21:09 ` [PATCH net-next 3/3] openvswitch: set IPS_CONFIRMED in tmpl status only when commit is set in conntrack Xin Long
2023-07-19 16:08 ` Aaron Conole
2024-06-17 20:10 ` Ilya Maximets
2024-06-18 11:34 ` Ilya Maximets
2024-06-18 14:58 ` Xin Long
2024-06-18 15:50 ` Ilya Maximets
2024-06-19 12:58 ` Ilya Maximets
2024-06-19 14:07 ` Xin Long
2024-06-19 17:30 ` Ilya Maximets
2024-06-19 20:11 ` Xin Long
2024-06-19 20:19 ` Florian Westphal [this message]
2024-06-19 20:50 ` Xin Long
2024-06-19 21:20 ` Florian Westphal
2024-06-19 22:10 ` Xin Long
2024-07-08 22:03 ` Xin Long
2024-07-08 22:38 ` Florian Westphal
2024-07-09 1:49 ` Xin Long
2024-07-09 5:49 ` Florian Westphal
2023-07-19 2:58 ` [PATCH net-next 0/3] net: handle the exp removal problem with ovs upcall properly Jakub Kicinski
2023-07-19 3:01 ` Florian Westphal
2023-07-19 16:12 ` Florian Westphal
2023-07-19 13:31 ` Aaron Conole
2023-07-20 8:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619201959.GA1513@breakpoint.cc \
--to=fw@strlen.de \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=i.maximets@ovn.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).