From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8C071AF698; Thu, 20 Jun 2024 13:26:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718890009; cv=none; b=MUJnAeuwAaxIOIptpBxYWbNfLialBA+XLskDgYNXhkv61I7fPZyDeuAp51pfNrQkaSJdnBOPzfYKe13INMcLJyP+FAwLfR2uoHk0S4CH2rk+/2TautGacIsrXVI7ZbT4CnYNUW7bqrRpM+PoQhQwu040EZr6Kc0jya93ulQ/0cc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718890009; c=relaxed/simple; bh=5+6TfDsfsUPrWZUmQaUBAnpLMQh6AHaEdq805oKkqZk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ar312JR/3E+r0N5wTDQgBl+0O3MD8/wWqWBqi24yICaBYMwbA/z9gj7RfmGSTJTX6Y6w026Ll0VIbZSB/zMHF5Q+DxO8DwrpnJXxmd5rRccl2iQ3jBuvBQ36Vix1iwkkg3Fx7RMfEtkH6A+e0OS3EogRFfna02dO38SgSk7ixxE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aeNJ18nm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aeNJ18nm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DBBE4C4AF07; Thu, 20 Jun 2024 13:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718890009; bh=5+6TfDsfsUPrWZUmQaUBAnpLMQh6AHaEdq805oKkqZk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aeNJ18nmIatSHrCUmEVR/NMNjnBbwhXS4k+lyHFW59cNyH+gf1/p2laaadaKfLsSq F6VDmey2HZdBEqVZkgHqGjfgeRWGLUYYfXL7disHafDeqVfpLbzDKVCJJZYZkepOme /aGGwfHRtXKyGd3luC74kkt0aevmVSHpSSCKaKoZSQSX6As7YJEe1F1B+qeg4CntwZ nuDC/wi9XRRzOGobarrvqlJTdWyUvpN7jrlPN52fZLdbzIRm3Xm30Dd4fFcp6FguMf rHXf3P6S0tXAuLTKHv+ATrdBHDtNCsFbvbJ0obuojrmk8tvPrwXvr8cmgDSg/LmOTf V2faqBDfyeRyg== Date: Thu, 20 Jun 2024 06:26:47 -0700 From: Jakub Kicinski To: Adam Young Cc: admiyo@os.amperecomputing.com, Jeremy Kerr , Matt Johnston , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] mctp pcc: Implement MCTP over PCC Transport Message-ID: <20240620062647.1111c801@kernel.org> In-Reply-To: <652e2d45-749e-4492-a00c-c0a2d15ab3a3@amperemail.onmicrosoft.com> References: <20240513173546.679061-1-admiyo@os.amperecomputing.com> <20240619200552.119080-1-admiyo@os.amperecomputing.com> <20240619200552.119080-4-admiyo@os.amperecomputing.com> <20240619162642.32f129c4@kernel.org> <652e2d45-749e-4492-a00c-c0a2d15ab3a3@amperemail.onmicrosoft.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 19 Jun 2024 23:24:41 -0400 Adam Young wrote: > > drivers/net/mctp/mctp-pcc.c:344:3: error: field designator 'owner' does= not refer to any field in type 'struct acpi_driver' > > 344 | .owner =3D THIS_MODULE, > > | ~^~~~~~~~~~~~~~~~~~~ =20 >=20 > Not sure how you are getting that last error.=C2=A0 I do not, and the v6.= 9.3=20 > code base has this in include/acpi/acpi_bus.h at line 166 v6.9.3 is not a development kernel. Your patches will be merged to net-next. Read more of the process doc I linked in the previous message. > That runs clean. It doesn't on patches 1 and 2, but you're right, I think it's intentional / because of the "historical" ACPI coding style :(