From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B224F1AB50E for ; Thu, 20 Jun 2024 10:48:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718880518; cv=none; b=VUkHMLgifp8H/ZnHfILyURkNM+6Xz3VWxsW7MX9aJ0Q4CKuePaYwQcebEREowgmV/74NrqIAUw8vy/j/nzarnCqINTE6qnmAHWcvuZdSdrHLqEb2T6mAN67lDsPEOXkbfyyvDNavN2HvKjK3tWl2dSE7xCE8loprBkgGkvnkKmA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718880518; c=relaxed/simple; bh=Esbbz8DxthG1H39auhHjtQPDB7fwYFEeOZT0QKAbq+0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Yh/4lnVYbWuKpJeFzLgAbFgd/OgbjVmYfZ0XR3KrkQuH2fSkbrF7dfoogBsomNQekZWTTgVCA7KOIYyMb8KFgdMwhAwKrNie5DdZ3v/TF5vL6RbnVgj8RrhjlzwduspDgizAblH+qBVXxUUeS+yI4ngskYJJFmnu+fdkI2AO1b4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VaEBwnYs; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VaEBwnYs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718880515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gvLoEiL6M3Ecn2PWS+83Cift4+fMJo1jASRKaS5VqNk=; b=VaEBwnYsRwmq/pvxWEm+oyRyQceIOJm40GYAaIxv2n1bCgibSR8u+3fpv08LnX4VacDkMM kJSyowD4114aiQHSF/57Xs2T2banJhLpu1WfZsQUISPabLYouJ0T1GCUwzQPSOT1dnDniZ jGGxu8F3eLm/K/YPM14sUlOrXNRggCo= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-lLTx_hGdNv23gI2gdtrTBg-1; Thu, 20 Jun 2024 06:48:34 -0400 X-MC-Unique: lLTx_hGdNv23gI2gdtrTBg-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a6fc7cf2581so22392766b.1 for ; Thu, 20 Jun 2024 03:48:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718880513; x=1719485313; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gvLoEiL6M3Ecn2PWS+83Cift4+fMJo1jASRKaS5VqNk=; b=hXC7kR5NKFbqVwFpkoKQ/rVZSf+MjqpkbZJUnLSbc+rrW/MXD317h3B+xIP8izfTmr 3X9/alLVbI8GW3ZZkJjpNDYhXrv40bXBQ8UdWsu5JI3KsnvatHe8YYgjJ/soYIHlcHyl tt8D2FK6dtl05ufYk7z4Q56+7Z7ikSuPpnJFsV9hLVhedfUOmm260Wrmwzfot96UkO4Y /GWCl5POjKoaCiE5RwXiZGCGcYzh7c4RXKHlqj6O1ZQANWPFo86ptLqNbCyMaFAKwhHD 6IAVFCXmfdI7W2TH4j6P0k0mRf3YqYvHotP7fYPiZunFPdd1fenuYBAk4WGut2CBtWfP MRIg== X-Forwarded-Encrypted: i=1; AJvYcCUfOq0BKR3pRheep3Hok66U8SKPk4ctzlmqKFhSzU6bUYr/DusX1pbuVDGn+uB8K11FrjwRZeH9om0KgwjGuZUZRHtLm1QB X-Gm-Message-State: AOJu0YyfgK9xYovBacsdCUmyJ+6B7LJGATVT+Cew/8OsEcA01lGOEYV5 Ww26GzfiVOjPOwMVl4dXcbyXE1NGJADpGO17I+iPhYivkSrx+vsrj7ASV8O/C+GbfdlJctEp9sm akiWzeB7Z165DYJDsfeI4xpnOZKauvglQSGSCZ+cLo5F0QJOVlMJwaQ== X-Received: by 2002:a17:906:b093:b0:a6f:96c9:8413 with SMTP id a640c23a62f3a-a6f96c9844bmr486206366b.1.1718880512820; Thu, 20 Jun 2024 03:48:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHxm5CK1H/t+3GpM5+8lsyLlBVkMoa7cdCIk3pXWs0yqp1VCYZUDSArK0iA4te8i1gL0nB8xw== X-Received: by 2002:a17:906:b093:b0:a6f:96c9:8413 with SMTP id a640c23a62f3a-a6f96c9844bmr486203666b.1.1718880512262; Thu, 20 Jun 2024 03:48:32 -0700 (PDT) Received: from redhat.com ([2.52.146.100]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f56f43220sm749966966b.185.2024.06.20.03.48.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 03:48:31 -0700 (PDT) Date: Thu, 20 Jun 2024 06:48:26 -0400 From: "Michael S. Tsirkin" To: Paolo Abeni Cc: Xuan Zhuo , netdev@vger.kernel.org, Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , virtualization@lists.linux.dev, bpf@vger.kernel.org Subject: Re: [PATCH net-next v6 10/10] virtio_net: xsk: rx: free the unused xsk buffer Message-ID: <20240620064818-mutt-send-email-mst@kernel.org> References: <20240618075643.24867-1-xuanzhuo@linux.alibaba.com> <20240618075643.24867-11-xuanzhuo@linux.alibaba.com> <38db3facdfefbefecd367ccce2e9b094d0b0314d.camel@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38db3facdfefbefecd367ccce2e9b094d0b0314d.camel@redhat.com> On Thu, Jun 20, 2024 at 12:46:24PM +0200, Paolo Abeni wrote: > On Tue, 2024-06-18 at 15:56 +0800, Xuan Zhuo wrote: > > Release the xsk buffer, when the queue is releasing or the queue is > > resizing. > > > > Signed-off-by: Xuan Zhuo > > --- > > drivers/net/virtio_net.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > index cfa106aa8039..33695b86bd99 100644 > > --- a/drivers/net/virtio_net.c > > +++ b/drivers/net/virtio_net.c > > @@ -967,6 +967,11 @@ static void virtnet_rq_unmap_free_buf(struct virtqueue *vq, void *buf) > > > > rq = &vi->rq[i]; > > > > + if (rq->xsk.pool) { > > + xsk_buff_free((struct xdp_buff *)buf); > > + return; > > + } > > + > > if (!vi->big_packets || vi->mergeable_rx_bufs) > > virtnet_rq_unmap(rq, buf, 0); > > > I'm under the impression this should be squashed in a previous patch, > likely "virtio_net: xsk: bind/unbind xsk for rx" > > Thanks, > > Paolo agreed, looks weird.