From: Kory Maincent <kory.maincent@bootlin.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Liang Li <liali@redhat.com>
Subject: Re: [PATCH net] bonding: fix incorrect software timestamping report
Date: Thu, 20 Jun 2024 11:13:01 +0200 [thread overview]
Message-ID: <20240620111301.4b7d10e8@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <20240620085626.1123399-1-liuhangbin@gmail.com>
On Thu, 20 Jun 2024 16:56:26 +0800
Hangbin Liu <liuhangbin@gmail.com> wrote:
> The __ethtool_get_ts_info function returns directly if the device has a
> get_ts_info() method. For bonding with an active slave, this works correctly
> as we simply return the real device's timestamping information. However,
> when there is no active slave, we only check the slave's TX software
> timestamp information. We still need to set the phc index and RX timestamp
> information manually. Otherwise, the result will be look like:
>
> Time stamping parameters for bond0:
> Capabilities:
> software-transmit
> PTP Hardware Clock: 0
> Hardware Transmit Timestamp Modes: none
> Hardware Receive Filter Modes: none
>
> This issue does not affect VLAN or MACVLAN devices, as they only have one
> downlink and can directly use the downlink's timestamping information.
Acked-by: Kory Maincent <kory.maincent@bootlin.com>
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-06-20 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 8:56 [PATCH net] bonding: fix incorrect software timestamping report Hangbin Liu
2024-06-20 9:13 ` Kory Maincent [this message]
2024-06-21 10:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620111301.4b7d10e8@kmaincent-XPS-13-7390 \
--to=kory.maincent@bootlin.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=liali@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).