From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D032A50288 for ; Thu, 20 Jun 2024 09:13:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718874793; cv=none; b=Un++amHJ7/kvY6/qybTUHLnaoZYRPbpuj86Uj254dcAJNhL0IBkqxD6zrzcQTNSNzzOPd0AOS0Nn1xrJNA3bP3bz6QT2V8j+z6pY/nOrXUU1zl8nd6G4cmLeSbzhFtMciq93gk728l3yPB1Ufi4gbGo2OzUoHBRaTlUfPXIivbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718874793; c=relaxed/simple; bh=lXOPQpBk/f62CLRXkJR3Wa/hCKJD+YgsOuEegSmWFD0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=m5Zk0rmlv9ihMEAbJFCxKliUGUGLQhzw0QT/VgKj6Vbz6pYRZOeXV/nghTlg1rNhlV6ttx9ze3qt6TKaJXDjLHpBozY3vL+oVwxQyKQOeiBhot9a/uOlwNkjfzZmEuXtH15FdH7KBoo35nJlp5vik8yK3DyBxMPO/UCPcYplTR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=mYsFFleS; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="mYsFFleS" Received: by mail.gandi.net (Postfix) with ESMTPSA id C44C560006; Thu, 20 Jun 2024 09:13:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1718874783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DsfVmJ5Q9dxhq88M34smdo4slbsb4YEgY+RxVLQeXDc=; b=mYsFFleS4FvCcX528MmYj7L95k6TzOkQwW7ZZQSpQkB1lK7WBh69N1XWD1WfFT0qk+MsRr Alr+r3WEaW5O+A1Vm8wk3dErb3SH9Iynq1VAmY67S/t2J63mTI2S6B+SzdkHcR5fIOgIJm VkoF0xHaF69f/eUDf5AjEompqsRpP7B5wBaaV+S2Huj4w7OjDLl9pYR/xvw0xT6ji9LUlN ChrfC0uHZ0WVFrlqhRFxKdHO2uNv7u5MYXHQVP9w18m3gkqbL0OqPvtGamatcrM1Vol2B+ WdowgFLFzYr+QEqYVYDVpaaOFM/izvQ+LjDtDxOSzP1XB7L+BsQ9OaJPTkfGmQ== Date: Thu, 20 Jun 2024 11:13:01 +0200 From: Kory Maincent To: Hangbin Liu Cc: netdev@vger.kernel.org, Jay Vosburgh , Andy Gospodarek , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Florian Fainelli , Liang Li Subject: Re: [PATCH net] bonding: fix incorrect software timestamping report Message-ID: <20240620111301.4b7d10e8@kmaincent-XPS-13-7390> In-Reply-To: <20240620085626.1123399-1-liuhangbin@gmail.com> References: <20240620085626.1123399-1-liuhangbin@gmail.com> Organization: bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: kory.maincent@bootlin.com On Thu, 20 Jun 2024 16:56:26 +0800 Hangbin Liu wrote: > The __ethtool_get_ts_info function returns directly if the device has a > get_ts_info() method. For bonding with an active slave, this works correc= tly > as we simply return the real device's timestamping information. However, > when there is no active slave, we only check the slave's TX software > timestamp information. We still need to set the phc index and RX timestamp > information manually. Otherwise, the result will be look like: >=20 > Time stamping parameters for bond0: > Capabilities: > software-transmit > PTP Hardware Clock: 0 > Hardware Transmit Timestamp Modes: none > Hardware Receive Filter Modes: none >=20 > This issue does not affect VLAN or MACVLAN devices, as they only have one > downlink and can directly use the downlink's timestamping information. Acked-by: Kory Maincent -- K=C3=B6ry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com