From: Vladimir Oltean <olteanv@gmail.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Tristram.Ha@microchip.com,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Simon Horman <horms@kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
"Ricardo B. Marliere" <ricardo@marliere.net>,
Casper Andersson <casper.casan@gmail.com>,
linux-kernel@vger.kernel.org,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v2 net-next] net: dsa: Allow only up to two HSR HW offloaded ports for KSZ9477
Date: Thu, 20 Jun 2024 15:06:41 +0300 [thread overview]
Message-ID: <20240620120641.jr2m4zpnzzjqeycq@skbuf> (raw)
In-Reply-To: <20240620140044.07191e24@wsk>
On Thu, Jun 20, 2024 at 02:00:44PM +0200, Lukasz Majewski wrote:
> In general I do understand your concerns - however, as I've stated this
> patch fixes oddity of the KSZ9477. I can test it with it.
> To keep it short: I do see your point, but I believe that it is out of
> the scope for this particular patch.
So that's it? Can't test with anything other than KSZ9477 => don't care
about anything else, and will ignore review feedback, even if the static
analysis of the code plausibly points to a more widespread issue?
As the author of commit 5055cccfc2d1 ("net: hsr: Provide RedBox support
(HSR-SAN)"), who do you think should be responsible of taking care that
it plays well with existing offloading drivers?
next prev parent reply other threads:[~2024-06-20 12:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 13:42 [PATCH v2 net-next] net: dsa: Allow only up to two HSR HW offloaded ports for KSZ9477 Lukasz Majewski
2024-06-19 13:54 ` Dan Carpenter
2024-06-19 14:27 ` Andrew Lunn
2024-06-19 14:42 ` Vladimir Oltean
2024-06-19 15:10 ` Lukasz Majewski
2024-06-19 15:48 ` Vladimir Oltean
2024-06-19 15:59 ` Vladimir Oltean
2024-06-20 7:59 ` Lukasz Majewski
2024-06-20 9:02 ` Vladimir Oltean
2024-06-20 12:00 ` Lukasz Majewski
2024-06-20 12:06 ` Vladimir Oltean [this message]
2024-06-20 13:28 ` Lukasz Majewski
2024-06-20 14:33 ` Vladimir Oltean
2024-06-21 8:31 ` Lukasz Majewski
2024-06-21 8:43 ` Vladimir Oltean
2024-06-19 21:54 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620120641.jr2m4zpnzzjqeycq@skbuf \
--to=olteanv@gmail.com \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=casper.casan@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=ricardo@marliere.net \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox