From: Jakub Kicinski <kuba@kernel.org>
To: Sunil Kovvuri Goutham <sgoutham@marvell.com>
Cc: Huai-Yuan Liu <qq810974084@gmail.com>,
"jes@trained-monkey.org" <jes@trained-monkey.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"linux-hippi@sunsite.dk" <linux-hippi@sunsite.dk>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"baijiaju1990@gmail.com" <baijiaju1990@gmail.com>
Subject: Re: [PATCH V2] hippi: fix possible buffer overflow caused by bad DMA value in rr_start_xmit()
Date: Fri, 21 Jun 2024 08:34:45 -0700 [thread overview]
Message-ID: <20240621083445.34d805d2@kernel.org> (raw)
In-Reply-To: <BY3PR18MB47379D136DE21EDB8C1741CAC6C92@BY3PR18MB4737.namprd18.prod.outlook.com>
On Fri, 21 Jun 2024 05:11:41 +0000 Sunil Kovvuri Goutham wrote:
> >+ if (index >= TX_RING_ENTRIES) {
> >+ netdev_err(dev, "invalid index value %02x\n", index);
>
> Much better would be to use netif_msg_tx_err which can be
> enabled/disabled instead of dumping on console, which would be
> annoying if there are many errors.
Doesn't it require ethtool to be changed tho? This driver doesn't have
any ethtool ops AFAICT. I'd go for netdev_err_once().
But more importantly, I think you should stop the queue before
returning BUSY.
prev parent reply other threads:[~2024-06-21 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 12:23 [PATCH V2] hippi: fix possible buffer overflow caused by bad DMA value in rr_start_xmit() Huai-Yuan Liu
2024-06-21 5:11 ` Sunil Kovvuri Goutham
2024-06-21 15:34 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621083445.34d805d2@kernel.org \
--to=kuba@kernel.org \
--cc=baijiaju1990@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jes@trained-monkey.org \
--cc=linux-hippi@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qq810974084@gmail.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).