From: Vladimir Oltean <olteanv@gmail.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Tristram.Ha@microchip.com,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Simon Horman <horms@kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
"Ricardo B. Marliere" <ricardo@marliere.net>,
Casper Andersson <casper.casan@gmail.com>,
linux-kernel@vger.kernel.org,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v2 net-next] net: dsa: Allow only up to two HSR HW offloaded ports for KSZ9477
Date: Fri, 21 Jun 2024 11:43:46 +0300 [thread overview]
Message-ID: <20240621084346.4v5xc672zojr6dc2@skbuf> (raw)
In-Reply-To: <20240621103144.300a2c89@wsk>
On Fri, Jun 21, 2024 at 10:31:44AM +0200, Lukasz Majewski wrote:
> > That being said, I think the responsibility falls on your side here,
> > given that you introduced a new HSR port type and offload drivers
> > still implicitly think it's a ring port, because there's no API to
> > tell them otherwise.
>
> IMHO, the above problem is not related to the patch send here. It shall
> be addressed with new patch series.
Why is it not related? Testing for HSR port type is the explicit and
more predictable variant of your current patch that waits for the
3rd NETDEV_CHANGEUPPER notifier and implicitly associates it with an
interlink port. If you're going to add the ability to test for HSR port
type in offloading drivers anyway, I don't understand why you wouldn't
want to opt for a uniform approach in ksz9477.
next prev parent reply other threads:[~2024-06-21 8:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 13:42 [PATCH v2 net-next] net: dsa: Allow only up to two HSR HW offloaded ports for KSZ9477 Lukasz Majewski
2024-06-19 13:54 ` Dan Carpenter
2024-06-19 14:27 ` Andrew Lunn
2024-06-19 14:42 ` Vladimir Oltean
2024-06-19 15:10 ` Lukasz Majewski
2024-06-19 15:48 ` Vladimir Oltean
2024-06-19 15:59 ` Vladimir Oltean
2024-06-20 7:59 ` Lukasz Majewski
2024-06-20 9:02 ` Vladimir Oltean
2024-06-20 12:00 ` Lukasz Majewski
2024-06-20 12:06 ` Vladimir Oltean
2024-06-20 13:28 ` Lukasz Majewski
2024-06-20 14:33 ` Vladimir Oltean
2024-06-21 8:31 ` Lukasz Majewski
2024-06-21 8:43 ` Vladimir Oltean [this message]
2024-06-19 21:54 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621084346.4v5xc672zojr6dc2@skbuf \
--to=olteanv@gmail.com \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=casper.casan@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=ricardo@marliere.net \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).