From: Simon Horman <horms@kernel.org>
To: Karol Kolacinski <karol.kolacinski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH v2 iwl-net 2/3] ice: Don't process extts if PTP is disabled
Date: Fri, 21 Jun 2024 12:06:50 +0100 [thread overview]
Message-ID: <20240621110650.GB1098275@kernel.org> (raw)
In-Reply-To: <20240620123141.1582255-3-karol.kolacinski@intel.com>
On Thu, Jun 20, 2024 at 02:27:09PM +0200, Karol Kolacinski wrote:
> From: Jacob Keller <jacob.e.keller@intel.com>
>
> The ice_ptp_extts_event() function can race with ice_ptp_release() and
> result in a NULL pointer dereference which leads to a kernel panic.
>
> Panic occurs because the ice_ptp_extts_event() function calls
> ptp_clock_event() with a NULL pointer. The ice driver has already
> released the PTP clock by the time the interrupt for the next external
> timestamp event occurs.
>
> To fix this, modify the ice_ptp_extts_event() function to check the
> PTP state and bail early if PTP is not ready.
>
> Fixes: 172db5f91d5f ("ice: add support for auxiliary input/output pins")
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
> ---
> V1 -> V2: removed unnecessary hunk of code and adjusted commit message
Thanks for the update.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-06-21 11:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 12:27 [PATCH v2 iwl-net 0/3] ice: Fix incorrect input/output pin behavior Karol Kolacinski
2024-06-20 12:27 ` [PATCH v2 iwl-net 1/3] ice: Fix improper extts handling Karol Kolacinski
2024-06-21 11:16 ` Simon Horman
2024-06-25 7:07 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-06-20 12:27 ` [PATCH v2 iwl-net 2/3] ice: Don't process extts if PTP is disabled Karol Kolacinski
2024-06-21 11:06 ` Simon Horman [this message]
2024-06-25 7:08 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-06-20 12:27 ` [PATCH v2 iwl-net 3/3] ice: Reject pin requests with unsupported flags Karol Kolacinski
2024-06-21 11:04 ` Simon Horman
2024-06-25 7:08 ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621110650.GB1098275@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=karol.kolacinski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).