From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F89512D771; Fri, 21 Jun 2024 11:18:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718968730; cv=none; b=Evm81pmOFCUfzaPmH/jz80skvoPUZ0S7zJlCimdAH0yaGgWlOaJ/gUDJgHg2mvYI/qwKgLPBVvFsPPuhtn6ZVVTQ1d6RqJFtj8POzT9A543VfmbDgu40H6dxfS4wsEqjTOfu9U1JhCZM5OMfvZ2sunOAnkAQiWGkA1TGBDMzNvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718968730; c=relaxed/simple; bh=HfbIjyxVlOvSKRVZrwhoYszewBmElsV/Orv22ajzXTA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sXTkz+yWo0zG65hcl5fexg7B600UQh8UKe1lNuQXMiNVf+bb7q4RlrHJ5nJw5L6M3q2hlQj65pTm7VmRatAHwrCv8uf44+Jlz9KBU+wW1gRigPVmEYd04+eq481ZNPL6piM0JeKsEplu7/PTCwdV62Gz5ERdBuuEknXJiFJo9FQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V3XnesmB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V3XnesmB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 521D1C2BBFC; Fri, 21 Jun 2024 11:18:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718968730; bh=HfbIjyxVlOvSKRVZrwhoYszewBmElsV/Orv22ajzXTA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V3XnesmB6GvSGy81HjBWiwKZRiakH/Nv4MMWhfuuuDRfGll8SrNhFJixdUTo6eAkw wKP9vFPnADGFBn/FK2fbI8mqB3Z6i67e9P1oLF9uziC0g9+jxCP2XrZXqZFILVddz9 72n3iQxXJzq+oV5rKlyZYUW2JxgfyJ4+MyDfzGDvj0Mco5zOFFo0BCpvfXwIPUXw9Y sY+PByyBurfV5pC5wZgysIiVXUs8QKSFYm19Q0l621ehinW0R+shJiX21K5l6gfMqw ggF7LRo90wRoPwwbMLBstGTz+dHj9ifVQsa/0k8SiNKHNJDIWK83CJAeSAx9DrS1Ge lWmLoaBEqKdTA== Date: Fri, 21 Jun 2024 12:18:46 +0100 From: Simon Horman To: Jose Ignacio Tornos Martinez Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net v3] net: usb: ax88179_178a: improve link status logs Message-ID: <20240621111846.GD1098275@kernel.org> References: <20240620133439.102296-1-jtornosm@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240620133439.102296-1-jtornosm@redhat.com> On Thu, Jun 20, 2024 at 03:34:31PM +0200, Jose Ignacio Tornos Martinez wrote: > Avoid spurious link status logs that may ultimately be wrong; for example, > if the link is set to down with the cable plugged, then the cable is > unplugged and after this the link is set to up, the last new log that is > appearing is incorrectly telling that the link is up. > > In order to avoid errors, show link status logs after link_reset > processing, and in order to avoid spurious as much as possible, only show > the link loss when some link status change is detected. > > cc: stable@vger.kernel.org > Fixes: e2ca90c276e1 ("ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver") > Signed-off-by: Jose Ignacio Tornos Martinez Reviewed-by: Simon Horman