From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org,
kernel@pengutronix.de, Chen Ni <nichen@iscas.ac.cn>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH net 4/5] can: kvaser_usb: fix return value for hif_usb_send_regout
Date: Fri, 21 Jun 2024 13:23:39 +0200 [thread overview]
Message-ID: <20240621121739.434355-5-mkl@pengutronix.de> (raw)
In-Reply-To: <20240621121739.434355-1-mkl@pengutronix.de>
From: Chen Ni <nichen@iscas.ac.cn>
As the potential failure of usb_submit_urb(), it should be better to
return the err variable to catch the error.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Link: https://lore.kernel.org/all/20240521041020.1519416-1-nichen@iscas.ac.cn
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c b/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
index 8faf8a462c05..7292c81fc0cd 100644
--- a/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
+++ b/drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c
@@ -294,7 +294,7 @@ int kvaser_usb_send_cmd_async(struct kvaser_usb_net_priv *priv, void *cmd,
}
usb_free_urb(urb);
- return 0;
+ return err;
}
int kvaser_usb_can_rx_over_error(struct net_device *netdev)
--
2.43.0
next prev parent reply other threads:[~2024-06-21 12:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 11:23 [PATCH net 0/5] pull-request: can 2024-06-21 Marc Kleine-Budde
2024-06-21 11:23 ` [PATCH net 1/5] net: can: j1939: enhanced error handling for tightly received RTS messages in xtp_rx_rts_session_new Marc Kleine-Budde
2024-06-22 1:20 ` patchwork-bot+netdevbpf
2024-06-21 11:23 ` [PATCH net 2/5] net: can: j1939: Initialize unused data in j1939_send_one() Marc Kleine-Budde
2024-06-21 11:23 ` [PATCH net 3/5] net: can: j1939: recover socket queue on CAN bus error during BAM transmission Marc Kleine-Budde
2024-06-21 11:23 ` Marc Kleine-Budde [this message]
2024-06-21 11:23 ` [PATCH net 5/5] can: mcp251xfd: fix infinite loop when xmit fails Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621121739.434355-5-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).