From: Jakub Kicinski <kuba@kernel.org>
To: Ghadi Rahme <ghadi.rahme@canonical.com>
Cc: netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 net] bnx2x: Fix multiple UBSAN array-index-out-of-bounds
Date: Fri, 21 Jun 2024 13:38:35 -0700 [thread overview]
Message-ID: <20240621133835.2a9225f0@kernel.org> (raw)
In-Reply-To: <1fee07fd-3beb-4201-9575-5ad630386e2f@canonical.com>
On Thu, 20 Jun 2024 17:59:42 +0300 Ghadi Rahme wrote:
> I have tested this approach and it worked fine so I am more comfortable now
> changing the patch an sending in a v3 undoing the changes in v2 and simply
> increasing the array size. I believe now that using FP_SB_MAX_E1x instead
> of FP_SB_MAX_E2 to define the array size might have been an oversight when
> updating the driver to take full advantage of the E2 after it was just
> limiting itself to the capabilities of an E1x.
Sounds good! Just to be clear, please do include the explanations you
provided here in the commit message, with the necessary edits. There's
no limit on the length of the commit message.
prev parent reply other threads:[~2024-06-21 20:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 15:44 [PATCH v2 net] bnx2x: Fix multiple UBSAN array-index-out-of-bounds Ghadi Elie Rahme
2024-06-13 12:36 ` Michael Ellerman
2024-06-13 14:48 ` Jakub Kicinski
2024-06-20 14:59 ` Ghadi Rahme
2024-06-21 20:38 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621133835.2a9225f0@kernel.org \
--to=kuba@kernel.org \
--cc=ghadi.rahme@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).