From: Jakub Kicinski <kuba@kernel.org>
To: David Wei <dw@davidwei.uk>
Cc: Michael Chan <michael.chan@broadcom.com>,
Andy Gospodarek <andrew.gospodarek@broadcom.com>,
Adrian Alvarado <adrian.alvarado@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
netdev@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>,
David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v3 2/2] bnxt_en: implement netdev_queue_mgmt_ops
Date: Fri, 21 Jun 2024 17:20:53 -0700 [thread overview]
Message-ID: <20240621172053.258074e7@kernel.org> (raw)
In-Reply-To: <20240619062931.19435-3-dw@davidwei.uk>
On Tue, 18 Jun 2024 23:29:31 -0700 David Wei wrote:
> + /* At this point, this NAPI instance has another page pool associated
> + * with it. Disconnect here before freeing the old page pool to avoid
> + * warnings.
> + */
> + rxr->page_pool->p.napi = NULL;
> + page_pool_destroy(rxr->page_pool);
> + rxr->page_pool = NULL;
What's the warning you hit?
We should probably bring back page_pool_unlink_napi(),
if this is really needed.
next prev parent reply other threads:[~2024-06-22 0:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 6:29 [PATCH net-next v3 0/2] bnxt_en: implement netdev_queue_mgmt_ops David Wei
2024-06-19 6:29 ` [PATCH net-next v3 1/2] bnxt_en: split rx ring helpers out from ring helpers David Wei
2024-06-20 16:54 ` Simon Horman
2024-06-19 6:29 ` [PATCH net-next v3 2/2] bnxt_en: implement netdev_queue_mgmt_ops David Wei
2024-06-20 16:54 ` Simon Horman
2024-06-22 0:20 ` Jakub Kicinski [this message]
2024-06-24 18:20 ` David Wei
2024-06-24 22:02 ` Jakub Kicinski
2024-06-24 22:50 ` David Wei
2024-06-21 9:20 ` [PATCH net-next v3 0/2] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621172053.258074e7@kernel.org \
--to=kuba@kernel.org \
--cc=adrian.alvarado@broadcom.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).