public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Kory Maincent <kory.maincent@bootlin.com>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org
Subject: Re: Netlink specs, help dealing with nested array
Date: Fri, 21 Jun 2024 17:56:17 +0200	[thread overview]
Message-ID: <20240621175617.496f85a5@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <CAD4GDZworgYs12TArypDvTCqU7_FB7V-+vxhe3VbpQVEHSdutQ@mail.gmail.com>

On Fri, 21 Jun 2024 16:27:57 +0100
Donald Hunter <donald.hunter@gmail.com> wrote:

> On Fri, 21 Jun 2024 at 16:19, Jakub Kicinski <kuba@kernel.org> wrote:
>  [...]  
>  [...]  
> >
> > You're (correctly) formatting your data as a basic multi-attr.
> > Instead of:
> >
> > +        name: c33-pse-pw-limit-ranges
> > +        name-prefix: ethtool-a-
> > +        type: indexed-array
> > +        sub-type: nest
> > +        nested-attributes: c33-pse-pw-limit
> >
> > use:
> >
> > +        name: c33-pse-pw-limit-ranges
> > +        name-prefix: ethtool-a-
> > +        type: nest
> > +        multi-attr: true
> > +        nested-attributes: c33-pse-pw-limit  
> 
> Ah yes, I was "fixing" things in the wrong direction. Sorry for the confusion.

Thanks Donald and Jakub!
It is working better with the right netlink specs.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

      reply	other threads:[~2024-06-21 15:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21 14:15 Netlink specs, help dealing with nested array Kory Maincent
2024-06-21 15:14 ` Donald Hunter
2024-06-21 15:19 ` Jakub Kicinski
2024-06-21 15:27   ` Donald Hunter
2024-06-21 15:56     ` Kory Maincent [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240621175617.496f85a5@kmaincent-XPS-13-7390 \
    --to=kory.maincent@bootlin.com \
    --cc=donald.hunter@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox